From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-94882-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 17838 invoked by alias); 26 Sep 2012 20:01:37 -0000
Received: (qmail 17829 invoked by uid 22791); 26 Sep 2012 20:01:36 -0000
X-SWARE-Spam-Status: No, hits=-6.9 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 26 Sep 2012 20:01:24 +0000
Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q8QK1HJe011446	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Wed, 26 Sep 2012 16:01:18 -0400
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q8QK1GD6023520	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Wed, 26 Sep 2012 16:01:16 -0400
From: Tom Tromey <tromey@redhat.com>
To: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [RFA] Add missing gdb_bfd.h includes
References: <18620.4427075156$1348564388@news.gmane.org>
Date: Wed, 26 Sep 2012 20:01:00 -0000
In-Reply-To: <18620.4427075156$1348564388@news.gmane.org> (Pierre Muller's	message of "Tue, 25 Sep 2012 11:12:32 +0200")
Message-ID: <87a9wcy2no.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-09/txt/msg00605.txt.bz2

>>>>> "Pierre" == Pierre Muller <pierre.muller@ics-cnrs.unistra.fr> writes:

Pierre> Is this OK?

Yes, thank you.

Pierre> As usual, 
Pierre>  1) I am not  sure about correct wording for ChangeLog

What you wrote is fine.

Pierre>  2) I never really understood the ordering logic (or to
Pierre> be more precise, if there is an ordering logic) of C headers
Pierre> in C source files, thus I inserted them more or less randomly...
 
There should not be many strong ordering dependencies in gdb, aside from
the rule that defs.h has to come first.  I wouldn't worry about it in
general.

Tom