From: Tom Tromey <tromey@redhat.com>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] [RFC] Fix ptype bug actually exercised in userdef.exp
Date: Wed, 13 Feb 2013 20:57:00 -0000 [thread overview]
Message-ID: <87a9r8kk4r.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20130213203131.30816.4686.stgit@brno.lan> (Pedro Alves's message of "Wed, 13 Feb 2013 20:31:31 +0000")
>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
Pedro> This patch fixes it. The issue is that we're entering the VALUE_LVAL
Pedro> (x) == lval_memory branch by mistake for references. The fix is just
Pedro> to swap the tests so references are checked first, like value_addr
Pedro> also handles references first.
Pedro> Comments?
It looks reasonable to me.
Tom
next prev parent reply other threads:[~2013-02-13 20:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-13 20:31 Pedro Alves
2013-02-13 20:35 ` Pedro Alves
2013-02-13 20:57 ` Tom Tromey [this message]
2013-02-14 12:53 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a9r8kk4r.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox