From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-98481-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 4791 invoked by alias); 13 Feb 2013 20:57:04 -0000
Received: (qmail 4781 invoked by uid 22791); 13 Feb 2013 20:57:02 -0000
X-SWARE-Spam-Status: No, hits=-6.4 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 13 Feb 2013 20:56:54 +0000
Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r1DKurgw026036	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)	for <gdb-patches@sourceware.org>; Wed, 13 Feb 2013 15:56:53 -0500
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r1DKuqFY025764	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Wed, 13 Feb 2013 15:56:53 -0500
From: Tom Tromey <tromey@redhat.com>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] [RFC] Fix ptype bug actually exercised in userdef.exp
References: <20130213203131.30816.4686.stgit@brno.lan>
Date: Wed, 13 Feb 2013 20:57:00 -0000
In-Reply-To: <20130213203131.30816.4686.stgit@brno.lan> (Pedro Alves's message	of "Wed, 13 Feb 2013 20:31:31 +0000")
Message-ID: <87a9r8kk4r.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.92 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2013-02/txt/msg00331.txt.bz2

>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:

Pedro> This patch fixes it.  The issue is that we're entering the VALUE_LVAL
Pedro> (x) == lval_memory branch by mistake for references.  The fix is just
Pedro> to swap the tests so references are checked first, like value_addr
Pedro> also handles references first.

Pedro> Comments?

It looks reasonable to me.

Tom