From: Tom Tromey <tromey@redhat.com>
To: Doug Evans <dje@google.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: FYI: fix test name in gdb-index.exp
Date: Wed, 28 Aug 2013 15:58:00 -0000 [thread overview]
Message-ID: <87a9k1x0ww.fsf@fleche.redhat.com> (raw)
In-Reply-To: <CADPb22TJB-ibCvZXrQNOgTW9kVwP2oj7HCK6OWCEct+bUbRxRg@mail.gmail.com> (Doug Evans's message of "Wed, 28 Aug 2013 07:55:14 -0700")
Doug> TIL: It's not just that test names have to be unique, but they can no
Doug> longer include build directory names because the latter can be machine
Doug> generated, and when diff'ing before/after runs it can lead to spurious
Doug> output needing investigating.
Yeah, I think it's actually always been that way.
I've fixed a number of these over the years.
Basically anything that makes the test names differ across runs is bad.
This is hard to fix in the general case but something like the directory
name is an easy one.
Doug> Good to know, thanks. And good thing to add to the testcase cookbook.
Will do.
Tom
prev parent reply other threads:[~2013-08-28 15:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-28 14:20 Tom Tromey
2013-08-28 14:55 ` Doug Evans
2013-08-28 15:58 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a9k1x0ww.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox