From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6037 invoked by alias); 28 Aug 2013 15:58:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6024 invoked by uid 89); 28 Aug 2013 15:58:27 -0000 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 28 Aug 2013 15:58:27 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.6 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r7SFwODx015087 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 28 Aug 2013 11:58:24 -0400 Received: from barimba (ovpn-113-142.phx2.redhat.com [10.3.113.142]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r7SFwNPI000828 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 28 Aug 2013 11:58:24 -0400 From: Tom Tromey To: Doug Evans Cc: gdb-patches Subject: Re: FYI: fix test name in gdb-index.exp References: <87vc2px5g3.fsf@fleche.redhat.com> Date: Wed, 28 Aug 2013 15:58:00 -0000 In-Reply-To: (Doug Evans's message of "Wed, 28 Aug 2013 07:55:14 -0700") Message-ID: <87a9k1x0ww.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-08/txt/msg00836.txt.bz2 Doug> TIL: It's not just that test names have to be unique, but they can no Doug> longer include build directory names because the latter can be machine Doug> generated, and when diff'ing before/after runs it can lead to spurious Doug> output needing investigating. Yeah, I think it's actually always been that way. I've fixed a number of these over the years. Basically anything that makes the test names differ across runs is bad. This is hard to fix in the general case but something like the directory name is an easy one. Doug> Good to know, thanks. And good thing to add to the testcase cookbook. Will do. Tom