From: Tom Tromey <tromey@redhat.com>
To: Sergio Durigan Junior <sergiodj@redhat.com>
Cc: Honggyu Kim <hong.gyu.kim@lge.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH v2] Remove duplicated include in gdb directory
Date: Mon, 06 Jan 2014 16:37:00 -0000 [thread overview]
Message-ID: <87a9f9oym6.fsf@fleche.redhat.com> (raw)
In-Reply-To: <m3d2k56acm.fsf@redhat.com> (Sergio Durigan Junior's message of "Mon, 06 Jan 2014 01:46:33 -0200")
>>>>> "Sergio" == Sergio Durigan Junior <sergiodj@redhat.com> writes:
Sergio> Thanks for the patch, Honggyu. I believe you have tested it by
Sergio> building GDB with --enable-targets=all, right?
That ordinarily would not be quite sufficient since this patch also
touches *-nat parts. However, reading the patch I think it is obviously
correct. None of the removed includes are "tricky" ones and the only
odd case I saw (the osdata.c change) really is correct.
Sergio> It needs a ChangeLog (mechanical), and it seems to be simple enough to
Sergio> be committed without needing a copyright assignment (I don't see your
Sergio> name in the MAINTAINERS file).
Agreed on both counts.
Sergio> Other than that, let's wait for some maintainer to give the
Sergio> green light.
You have it.
Tom
next prev parent reply other threads:[~2014-01-06 16:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-06 1:53 Honggyu Kim
2014-01-06 3:46 ` Sergio Durigan Junior
2014-01-06 5:13 ` Honggyu Kim
2014-01-06 6:48 ` Honggyu Kim
2014-01-06 14:55 ` Sergio Durigan Junior
2014-01-06 16:37 ` Tom Tromey [this message]
2014-01-06 19:08 ` Sergio Durigan Junior
2014-01-07 2:44 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a9f9oym6.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=hong.gyu.kim@lge.com \
--cc=sergiodj@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox