From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25303 invoked by alias); 6 Jan 2014 16:37:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 25293 invoked by uid 89); 6 Jan 2014 16:37:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 06 Jan 2014 16:37:27 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s06GbNCQ014471 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 6 Jan 2014 11:37:24 -0500 Received: from barimba (ovpn-113-85.phx2.redhat.com [10.3.113.85]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id s06GbLIq025186 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 6 Jan 2014 11:37:22 -0500 From: Tom Tromey To: Sergio Durigan Junior Cc: Honggyu Kim , gdb-patches@sourceware.org Subject: Re: [PATCH v2] Remove duplicated include in gdb directory References: <1388973207-31270-1-git-send-email-hong.gyu.kim@lge.com> Date: Mon, 06 Jan 2014 16:37:00 -0000 In-Reply-To: (Sergio Durigan Junior's message of "Mon, 06 Jan 2014 01:46:33 -0200") Message-ID: <87a9f9oym6.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2014-01/txt/msg00061.txt.bz2 >>>>> "Sergio" == Sergio Durigan Junior writes: Sergio> Thanks for the patch, Honggyu. I believe you have tested it by Sergio> building GDB with --enable-targets=all, right? That ordinarily would not be quite sufficient since this patch also touches *-nat parts. However, reading the patch I think it is obviously correct. None of the removed includes are "tricky" ones and the only odd case I saw (the osdata.c change) really is correct. Sergio> It needs a ChangeLog (mechanical), and it seems to be simple enough to Sergio> be committed without needing a copyright assignment (I don't see your Sergio> name in the MAINTAINERS file). Agreed on both counts. Sergio> Other than that, let's wait for some maintainer to give the Sergio> green light. You have it. Tom