From: jose.marchesi@oracle.com (Jose E. Marchesi)
To: Yao Qi <qiyaoltc@gmail.com>
Cc: Weimin Pan <weimin.pan@oracle.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH v4] gdb: ADI support
Date: Tue, 25 Jul 2017 15:31:00 -0000 [thread overview]
Message-ID: <87a83sleio.fsf@oracle.com> (raw)
In-Reply-To: <86o9s8pmyg.fsf@gmail.com> (Yao Qi's message of "Tue, 25 Jul 2017 16:15:19 +0100")
> +/* Per-process ADI stat info. */
> +
> +struct sparc64_adi_info
> +{
> + /* The process identifier. */
> + pid_t pid;
> +
> + /* The ADI stat. */
> + struct adi_stat_t stat;
> +
> + /* Linked list. */
> + struct sparc64_adi_info *next;
> +};
Use C++ STL list. I suggested it on the v3 review.
General question: what's wrong with using a simple linked list of
structs if that is the developer's preference, and/or it follows the
current style of the surrounding code? (Not saying it is in this case,
that's up to Weimin to say.)
As far as I can see the usage of STL is not mandated by the GDB coding
standards (as documented in the wiki) and developers may want to avoid
them in many circumstances.
next prev parent reply other threads:[~2017-07-25 15:31 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-19 0:49 Weimin Pan
2017-07-25 15:16 ` Yao Qi
2017-07-25 15:31 ` Jose E. Marchesi [this message]
2017-07-25 16:44 ` Yao Qi
2017-07-26 21:12 ` Wei-min Pan
2017-07-27 11:17 ` Yao Qi
2017-07-27 16:34 ` Wei-min Pan
2017-07-28 10:30 ` Yao Qi
2017-07-28 16:34 ` Wei-min Pan
[not found] ` <868tj3ml8s.fsf@gmail.com>
2017-08-01 17:41 ` Wei-min Pan
2017-07-25 19:19 Weimin Pan
2017-07-25 20:18 ` Simon Marchi
2017-07-25 21:03 ` Jose E. Marchesi
2017-07-25 22:37 Weimin Pan
2017-08-01 23:30 Weimin Pan
2017-08-02 7:55 ` Yao Qi
2017-08-02 18:00 ` Wei-min Pan
2017-08-04 11:57 ` Yao Qi
2017-08-04 22:46 Weimin Pan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a83sleio.fsf@oracle.com \
--to=jose.marchesi@oracle.com \
--cc=gdb-patches@sourceware.org \
--cc=qiyaoltc@gmail.com \
--cc=weimin.pan@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox