Re: [PATCH v4] gdb: ADI support

Wei-min Pan
2017-07-27T16:34:29Z

On 7/27/2017 4:16 AM, Yao Qi wrote:
> Wei-min Pan <weimin.pan@oracle.com> writes:
>
>>>> +##########################################
>>>> +set newadi "7"
>>>> +gdb_test "adi x shmaddr" "" "examine ADI"
>>> Can you match the output?
>> Here are the results of running this new test:
>>
> That is not what I mean. Your test leaves the PATTERN
> (the 2nd argument) empty,
>
> gdb_test "adi x shmaddr" "" "examine ADI"
>
> so it doesn't test much. You need to add PATTERN to match the expected
> output from command "adi x shmaddr".

The first "adi x shmaddr" command is mainly used to test that the ADI
information is available
at the address. Its value which can be anything is not tested. The
second "examine" command,
on the other hand, makes sure the new ADI version tag is being set
correctly at the address.

>
>> % make check TESTS="gdb.arch/sparc64-adi.exp"
>> ...
>> ...
>>
>> === gdb tests ===
>>
>> Schedule of variations:
>> unix
>>
>> Running target unix
>> Using /usr/share/dejagnu/baseboards/unix.exp as board description file
>> for target.
>> Using /usr/share/dejagnu/config/unix.exp as generic interface file for
>> target.
>> Using ~/binutils-gdb/gdb/testsuite/config/unix.exp as
>> tool-and-target-specific interface file.
>> Running ~/binutils-gdb/gdb/testsuite/gdb.arch/sparc64-adi.exp ...
>>
>> === gdb Summary ===
>>
>> # of expected passes 7
>> ...