Re: [PATCH v4] gdb: ADI support

Weimin Pan
2017-08-01T23:30:41Z

----- Original Message -----
> From: weimin.pan@oracle.com
> To: qiyaoltc@gmail.com
> Cc: gdb-patches@sourceware.org
> Sent: Tuesday, August 1, 2017 10:41:48 AM GMT -08:00 US/Canada Pacific
> Subject: Re: [PATCH v4] gdb: ADI support
>
> Thanks for your suggestions. There are 3 failures however.
>
>
> On 8/1/2017 7:10 AM, Yao Qi wrote:
> > Wei-min Pan <weimin.pan@oracle.com> writes:
> >
> >> (gdb) PASS: gdb.arch/sparc64-adi.exp: continue to breakpoint: continue
> >> to line breakpoint in main
> >> adi x shmaddr^M
> >> 0xfff800010002c000: 0 ^M
> > gdb_test "adi x shmaddr" "${hex}00:\t0" "examine ADI"
>
> It will pass if changed to
>
> gdb_test "adi x shmaddr" "${hex}00:.*\t0.*" "examine ADI"

Or change it to:

gdb_test "adi x shmaddr" "${hex}00:\t0 " "examine ADI"

>
>
> > gdb_test "adi x/100 shmaddr" "${hex}00:\t${newadi} ${newadi}" \
> > "examine new ADI"
>
> It will pass if changed to:
>
> gdb_test "adi x/100 shmaddr" "${hex}00:.*\t${newadi} ${newadi}.*" \
> "examine new ADI"

Or change it to:

gdb_test "adi x/100 shmaddr" "${hex}00:\t${newadi} ${newadi} " \
"examine new ADI"

>
> >> (gdb) PASS: gdb.arch/sparc64-adi.exp: reset ADI
> >> continue^M
> >> Continuing.^M
> >> ^M
> >> Program received signal SIGSEGV, Segmentation fault^M
> >> ADI precise mismatch while accessing address 0xfff8000100048000.^M
> >> 0xfff8000100129f38 in adi_set_version () from /usr/lib64/libadi.so^M
> > gdb_test "continue" \
> > [multi_line "Program received signal SIGSEGV, Segmentation fault" \
> > "ADI precise mismatch while accessing address $hex" ] \
> > "continue to sigsegv"
>
> And it will pass if changed to
>
> gdb_test "continue" \
> [multi_line ".*Program received signal SIGSEGV, Segmentation fault.*" \
> ".*ADI precise mismatch while accessing address $hex.*" ] \
> "continue to sigsegv"

Or change it to:

gdb_test "continue" \
[multi_line "Program received signal SIGSEGV, Segmentation fault.*" \
"ADI precise mismatch while accessing address $hex.*" ] \
"continue to sigsegv"