Re: [PATCH v4] gdb: ADI support

Weimin Pan
2017-08-04T22:46:56Z

> From: qiyaoltc@gmail.com
> To: weimin.pan@oracle.com
> Cc: gdb-patches@sourceware.org
> Sent: Friday, August 4, 2017 4:57:31 AM GMT -08:00 US/Canada Pacific
> Subject: Re: [PATCH v4] gdb: ADI support
>
> Wei-min Pan <weimin.pan@oracle.com> writes:
>
> > A trailing space is needed to separate tag values. I can change the code
> > so that no space is added for the last tag value:
> >
> > if (tags[v_idx] == 0xff) /* no version tag */
> > printf_filtered ("-");
> > else
> > printf_filtered ("%1X", tags[v_idx]);
> > if (cnt > 1)
> > printf_filtered (" ");
> >
> > and use your suggested "adi x" commands in the script.
>
> That will be great, thanks.

Please review the updated patch I just submitted.

Thanks.

>
> --
> Yao (齐尧)