From: Tom Tromey <tom@tromey.com>
To: Omair Javaid <omair.javaid@linaro.org>
Cc: Tom Tromey <tom@tromey.com>, GDB Patches <gdb-patches@sourceware.org>
Subject: Re: [RFA 1/2] Fix decoding of ARM VFP instructions
Date: Fri, 04 May 2018 17:07:00 -0000 [thread overview]
Message-ID: <87a7tf2vwf.fsf@tromey.com> (raw)
In-Reply-To: <CANW4E-0qnudezdKcWH+c64AUbK-LUjWanbgCuuHFUTGBSeT2sg@mail.gmail.com> (Omair Javaid's message of "Wed, 25 Apr 2018 02:09:51 +0500")
>>>>> "Omair" == Omair Javaid <omair.javaid@linaro.org> writes:
>> On 22 April 2018 at 02:47, Tom Tromey <tom@tromey.com> wrote:
>> -Wduplicated-cond pointed out that arm_record_vfp_data_proc_insn
>> checks "opc1 == 0x0b" twice. I filed this a while ago as
>> PR tdep/20362.
>>
>> Based on the ARM instruction manual at
>> https://www.scss.tcd.ie/~waldroj/3d1/arm_arm.pdf, I think the
>> instruction decoding in this function has two bugs.
[...]
Omair> Seems LGTM. Let me get back to you after running testsuite for regressions.
Did this work out?
Tom
next prev parent reply other threads:[~2018-05-04 17:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-21 21:47 [RFA 0/2] Add -Wduplicated-cond Tom Tromey
2018-04-21 21:47 ` [RFA 2/2] " Tom Tromey
2018-04-22 15:47 ` Pedro Alves
2018-04-24 23:07 ` Tom Tromey
2018-04-21 21:47 ` [RFA 1/2] Fix decoding of ARM VFP instructions Tom Tromey
2018-04-24 21:10 ` Omair Javaid
2018-05-04 17:07 ` Tom Tromey [this message]
2018-05-07 14:35 ` Pedro Alves
2018-04-23 15:36 ` [RFA 0/2] Add -Wduplicated-cond Sergio Durigan Junior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a7tf2vwf.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=omair.javaid@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox