From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 96690 invoked by alias); 4 May 2018 17:07:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 96391 invoked by uid 89); 4 May 2018 17:07:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=3d1, Javaid, javaid, omair X-HELO: gateway20.websitewelcome.com Received: from gateway20.websitewelcome.com (HELO gateway20.websitewelcome.com) (192.185.48.38) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 04 May 2018 17:07:00 +0000 Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway20.websitewelcome.com (Postfix) with ESMTP id 9E43A400EEFE6 for ; Fri, 4 May 2018 12:06:09 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id Ee9pfH3vilAdrEe9pfpL18; Fri, 04 May 2018 12:06:09 -0500 X-Authority-Reason: nr=8 Received: from 97-122-176-117.hlrn.qwest.net ([97.122.176.117]:46232 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1fEe9p-002Ret-CY; Fri, 04 May 2018 12:06:09 -0500 From: Tom Tromey To: Omair Javaid Cc: Tom Tromey , GDB Patches Subject: Re: [RFA 1/2] Fix decoding of ARM VFP instructions References: <20180421214721.7232-1-tom@tromey.com> <20180421214721.7232-2-tom@tromey.com> Date: Fri, 04 May 2018 17:07:00 -0000 In-Reply-To: (Omair Javaid's message of "Wed, 25 Apr 2018 02:09:51 +0500") Message-ID: <87a7tf2vwf.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Source-L: No X-Exim-ID: 1fEe9p-002Ret-CY X-Source-Sender: 97-122-176-117.hlrn.qwest.net (pokyo) [97.122.176.117]:46232 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-SW-Source: 2018-05/txt/msg00100.txt.bz2 >>>>> "Omair" == Omair Javaid writes: >> On 22 April 2018 at 02:47, Tom Tromey wrote: >> -Wduplicated-cond pointed out that arm_record_vfp_data_proc_insn >> checks "opc1 == 0x0b" twice. I filed this a while ago as >> PR tdep/20362. >> >> Based on the ARM instruction manual at >> https://www.scss.tcd.ie/~waldroj/3d1/arm_arm.pdf, I think the >> instruction decoding in this function has two bugs. [...] Omair> Seems LGTM. Let me get back to you after running testsuite for regressions. Did this work out? Tom