Re: [PATCH] [OBVIOUS] enable frame-filter short help uses disable instead of enable

[Tom Tromey <tom@tromey.com>]

>>>>> "Philippe" == Philippe Waroquiers <philippe.waroquiers@skynet.be> writes:

Philippe> Note that the Usage: string in the below still looks strange to me:
Philippe> the second 'enable' in
Philippe>      Usage: enable frame-filter enable DICTIONARY [NAME]
Philippe> should be removed (and similarly in the disable frame-filter).

Yes, I agree.

Philippe> Then, reading the 'help enable frame-filter', it looks like DICTIONARY is
Philippe> optional, but the Usage: seems to indicate it is mandatory.

Looking at the code it seems like the syntax is:

    enable frame-filter [all | DICTIONARY NAME]

Though there is a bug if you don't pass arguments at all:

    (gdb)  enable frame-filter 
    Traceback (most recent call last):
      File "/usr/share/gdb/python/gdb/command/frame_filters.py", line 238, in invoke
        command_tuple = _enable_parse_arg("enable frame-filter", arg)
      File "/usr/share/gdb/python/gdb/command/frame_filters.py", line 115, in _enable_parse_arg
        if argv[0] == "all" and argc > 1:
    IndexError: list index out of range
    Error occurred in Python command: list index out of range

Tom