From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28558 invoked by alias); 18 Sep 2018 04:35:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 28547 invoked by uid 89); 18 Sep 2018 04:35:30 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-7.3 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_1,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway36.websitewelcome.com Received: from gateway36.websitewelcome.com (HELO gateway36.websitewelcome.com) (192.185.193.119) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 18 Sep 2018 04:35:28 +0000 Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway36.websitewelcome.com (Postfix) with ESMTP id DC9A1400D46CD for ; Mon, 17 Sep 2018 22:40:45 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 27jTgTaoTRPoj27jTgq03e; Mon, 17 Sep 2018 23:35:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=8SuKKHGYiIE4RW1rsGNY4YajLXCeuSsmlJJgErZuXq4=; b=T0lldKCB9VYQ2iZ5N/xXc4rNWM pjLAAehD9EUC/bxxJu5u9hs7CYqsEBukPWJE55ba39XhqqHQQcW+FAiBy7UcEYO/90Q5UMXpuCDet d/gOKnQo4+7Hxh8Cd5vIwJ63p; Received: from 97-122-190-66.hlrn.qwest.net ([97.122.190.66]:54294 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1g27jT-003jBc-51; Mon, 17 Sep 2018 23:35:27 -0500 From: Tom Tromey To: Philippe Waroquiers Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] [OBVIOUS] enable frame-filter short help uses disable instead of enable References: <20180917222334.27753-1-philippe.waroquiers@skynet.be> <1537224109.3924.6.camel@skynet.be> Date: Tue, 18 Sep 2018 04:35:00 -0000 In-Reply-To: <1537224109.3924.6.camel@skynet.be> (Philippe Waroquiers's message of "Tue, 18 Sep 2018 00:41:49 +0200") Message-ID: <87a7ofmnht.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-09/txt/msg00618.txt.bz2 >>>>> "Philippe" == Philippe Waroquiers writes: Philippe> Note that the Usage: string in the below still looks strange to me: Philippe> the second 'enable' in Philippe> Usage: enable frame-filter enable DICTIONARY [NAME] Philippe> should be removed (and similarly in the disable frame-filter). Yes, I agree. Philippe> Then, reading the 'help enable frame-filter', it looks like DICTIONARY is Philippe> optional, but the Usage: seems to indicate it is mandatory. Looking at the code it seems like the syntax is: enable frame-filter [all | DICTIONARY NAME] Though there is a bug if you don't pass arguments at all: (gdb) enable frame-filter Traceback (most recent call last): File "/usr/share/gdb/python/gdb/command/frame_filters.py", line 238, in invoke command_tuple = _enable_parse_arg("enable frame-filter", arg) File "/usr/share/gdb/python/gdb/command/frame_filters.py", line 115, in _enable_parse_arg if argv[0] == "all" and argc > 1: IndexError: list index out of range Error occurred in Python command: list index out of range Tom