Re: [PATCH] Disambiguate info_print_options

[Tom Tromey <tom@tromey.com>]

>>>>> "Ali" == Ali Tamur via gdb-patches <gdb-patches@sourceware.org> writes:

Ali> struct info_print_options is defined in both symtab.c and stack.c, which is
Ali> an ODR violation. So, I am renaming one of them. (Please suggest a better
Ali> name, what I picked is not good).

Thank you for doing this.

I tend to think the naming of these "throwaway" structures isn't very
important.

That said, the comment just above reads:

/* Structure to hold the values of the options used by the 'info variables'
   and 'info functions' commands.  These correspond to the -q, -t, and -n
   options.  */

So how about "info_vars_funcs_options"?

Maybe make_info_sources_options_def_group should be renamed as well.
And perhaps info_print_command_completer.  My thinking here is that it
is best if the related names are all consistent.

thanks,
Tom