From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 84448 invoked by alias); 26 Jan 2020 16:10:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 84437 invoked by uid 89); 26 Jan 2020 16:10:36 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-8.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=Ali X-HELO: gateway22.websitewelcome.com Received: from gateway22.websitewelcome.com (HELO gateway22.websitewelcome.com) (192.185.46.225) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 26 Jan 2020 16:10:35 +0000 Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway22.websitewelcome.com (Postfix) with ESMTP id 050E06F2F for ; Sun, 26 Jan 2020 10:10:34 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id vkUbioaYrvYkQvkUcifU0S; Sun, 26 Jan 2020 10:10:34 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=P+ROtNvyaMJdOAFgT8mOpxawoDooqSJMCXvVGi1T+kY=; b=P+4UDN2R3J/0YxTDCbXqOs8Iq/ xHKm8SwwE/UUQXzBD43MSeGxQij8hB4eg4a4EPFgXOiN4eqL3+MGnyykTMaDDlYIL/sHZZS1DidQT aITCvDs3qT9ZLnisrebA+uRcO; Received: from 75-166-123-50.hlrn.qwest.net ([75.166.123.50]:57726 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1ivkUb-003RKv-P2; Sun, 26 Jan 2020 09:10:33 -0700 From: Tom Tromey To: "Ali Tamur via gdb-patches" Cc: Ali Tamur Subject: Re: [PATCH] Disambiguate info_print_options References: <20200125050825.53004-1-tamur@google.com> Date: Sun, 26 Jan 2020 16:15:00 -0000 In-Reply-To: <20200125050825.53004-1-tamur@google.com> (Ali Tamur via gdb-patches's message of "Fri, 24 Jan 2020 21:08:25 -0800") Message-ID: <87a76a6vwn.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2020-01/txt/msg00850.txt.bz2 >>>>> "Ali" == Ali Tamur via gdb-patches writes: Ali> struct info_print_options is defined in both symtab.c and stack.c, which is Ali> an ODR violation. So, I am renaming one of them. (Please suggest a better Ali> name, what I picked is not good). Thank you for doing this. I tend to think the naming of these "throwaway" structures isn't very important. That said, the comment just above reads: /* Structure to hold the values of the options used by the 'info variables' and 'info functions' commands. These correspond to the -q, -t, and -n options. */ So how about "info_vars_funcs_options"? Maybe make_info_sources_options_def_group should be renamed as well. And perhaps info_print_command_completer. My thinking here is that it is best if the related names are all consistent. thanks, Tom