From: Tom Tromey <tom@tromey.com>
To: Tom de Vries <tdevries@suse.de>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [gdb/cli] Add a progress meter
Date: Tue, 15 Dec 2020 13:28:16 -0700 [thread overview]
Message-ID: <87a6ue4xwf.fsf@tromey.com> (raw)
In-Reply-To: <2673dab0-5e37-e7dc-a6f8-bb764aa22d6a@suse.de> (Tom de Vries's message of "Sat, 12 Dec 2020 17:35:24 +0100")
>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
Tom> + - printed for not-a-tty:
Tom> + <NAME...done.
Tom> + if (!stream->isatty ())
Tom> + {
Tom> + fprintf_unfiltered (stream, "done.\n");
Tom> + gdb_flush (stream);
Tom> + }
We got rid of the "done" for symbol reading, so IMO we might as well
drop it here too.
Otherwise this looks good to me.
Tom
next prev parent reply other threads:[~2020-12-15 20:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-07 11:43 [PATCH] gdb: print size of downloaded debuginfod binary Martin Liška
2020-12-07 17:07 ` Simon Marchi via Gdb-patches
2020-12-08 10:16 ` Martin Liška
2020-12-08 14:28 ` Simon Marchi via Gdb-patches
2020-12-09 10:51 ` Martin Liška
2020-12-09 23:26 ` Tom de Vries
2020-12-10 8:26 ` Martin Liška
2020-12-10 19:21 ` Tom Tromey
2020-12-11 17:51 ` [gdb/cli] Add a progress meter Tom de Vries
2020-12-11 17:54 ` [PATCH] gdb: print size of downloaded debuginfod binary Tom de Vries
2020-12-11 19:23 ` Tom Tromey
2020-12-12 16:43 ` Tom de Vries
2020-12-15 20:29 ` Tom Tromey
2020-12-11 19:21 ` [gdb/cli] Add a progress meter Tom Tromey
2020-12-12 16:35 ` Tom de Vries
2020-12-15 20:28 ` Tom Tromey [this message]
2020-12-09 20:16 ` [PATCH] gdb: print size of downloaded debuginfod binary Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a6ue4xwf.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox