From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id sC+1JHgc2V/0EQAAWB0awg (envelope-from ) for ; Tue, 15 Dec 2020 15:28:40 -0500 Received: by simark.ca (Postfix, from userid 112) id 8F5411F0AA; Tue, 15 Dec 2020 15:28:40 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.4 required=5.0 tests=DKIM_SIGNED,MAILING_LIST_MULTI, RDNS_NONE,T_DKIM_INVALID,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 36CB81E590 for ; Tue, 15 Dec 2020 15:28:40 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3DA02385800A; Tue, 15 Dec 2020 20:28:39 +0000 (GMT) Received: from gateway31.websitewelcome.com (gateway31.websitewelcome.com [192.185.143.46]) by sourceware.org (Postfix) with ESMTPS id DDA9F385800A for ; Tue, 15 Dec 2020 20:28:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org DDA9F385800A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway31.websitewelcome.com (Postfix) with ESMTP id 216625FA0E for ; Tue, 15 Dec 2020 14:28:18 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id pGvhkvQbOHPnUpGvikBoFr; Tue, 15 Dec 2020 14:28:18 -0600 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Bf/IONwTO5k5eoBF5UGR4gGrlLUU/JiEvS54VBjMqLg=; b=Rv+Zo6a8FI5DkQT61+zcG8Ebnw 85pUP5y7BXlZ+VAgNDLNFeADhc/Wx4s6oEa+KVKBtRnwwkaw/hJNiV/CNReU7liy9OuJ3iojv2RpS 41iH/vbk5tMLUpEdNVx7j2i+r; Received: from 97-122-89-243.hlrn.qwest.net ([97.122.89.243]:49018 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1kpGvh-002uaH-Cs; Tue, 15 Dec 2020 13:28:17 -0700 From: Tom Tromey To: Tom de Vries Subject: Re: [gdb/cli] Add a progress meter References: <6ad82f30-0ca3-8b19-2907-d71f0dfecafe@suse.cz> <2c28a403-a169-0dc3-9b64-58484237c8c2@suse.cz> <72061fbb-b480-04ce-ef4a-fe13a7266885@suse.de> <87a6ulmppr.fsf@tromey.com> <5506b198-c504-0046-0559-bcc24538d31c@suse.de> <87k0togndu.fsf@tromey.com> <2673dab0-5e37-e7dc-a6f8-bb764aa22d6a@suse.de> X-Attribution: Tom Date: Tue, 15 Dec 2020 13:28:16 -0700 In-Reply-To: <2673dab0-5e37-e7dc-a6f8-bb764aa22d6a@suse.de> (Tom de Vries's message of "Sat, 12 Dec 2020 17:35:24 +0100") Message-ID: <87a6ue4xwf.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.89.243 X-Source-L: No X-Exim-ID: 1kpGvh-002uaH-Cs X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-89-243.hlrn.qwest.net (murgatroyd) [97.122.89.243]:49018 X-Source-Auth: tom+tromey.com X-Email-Count: 6 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tom Tromey , gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" >>>>> "Tom" == Tom de Vries writes: Tom> + - printed for not-a-tty: Tom> + + if (!stream->isatty ()) Tom> + { Tom> + fprintf_unfiltered (stream, "done.\n"); Tom> + gdb_flush (stream); Tom> + } We got rid of the "done" for symbol reading, so IMO we might as well drop it here too. Otherwise this looks good to me. Tom