Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Tom de Vries via Gdb-patches <gdb-patches@sourceware.org>
Cc: Simon Marchi <simark@simark.ca>
Subject: Re: [PATCH][gdb] Make execute_command_to_string return string on throw
Date: Wed, 20 Oct 2021 12:53:58 -0600	[thread overview]
Message-ID: <87a6j3v86x.fsf@tromey.com> (raw)
In-Reply-To: <f342e26c-2d0b-cb7a-3fc3-826f8ec02293@suse.de> (Tom de Vries via Gdb-patches's message of "Thu, 7 Oct 2021 18:15:19 +0200")

>> The code LGTM, but could you write / update a test for this?

Tom> The patch "[gdb/testsuite] Reimplement gdb.gdb/python-interrupts.exp as
Tom> unittest" uses this.  It checks the output of a command that is also
Tom> throwing a "Error while executing Python code".

FWIW the new self-test fails for me:

(gdb) maint selftest python
Running selftest python.
5
Self test failed: self-test failed at ../../binutils-gdb/gdb/python/python.c:1932
Ran 1 unit tests, 1 failed

thanks,
Tom

  parent reply	other threads:[~2021-10-20 18:56 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-11 12:02 Tom de Vries via Gdb-patches
2021-10-07 14:37 ` [PING][PATCH][gdb] " Tom de Vries via Gdb-patches
2021-10-07 15:33 ` [PATCH][gdb] " Simon Marchi
2021-10-07 16:15   ` Tom de Vries via Gdb-patches
2021-10-07 16:16     ` Simon Marchi
2021-10-20 18:53     ` Tom Tromey [this message]
2021-10-20 20:43       ` Tom de Vries via Gdb-patches
2021-10-20 22:14         ` Tom Tromey
2021-10-21 18:28           ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a6j3v86x.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=simark@simark.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox