From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id h3qLL0dmcGGFLgAAWB0awg (envelope-from ) for ; Wed, 20 Oct 2021 14:56:07 -0400 Received: by simark.ca (Postfix, from userid 112) id B15AA1F0BD; Wed, 20 Oct 2021 14:56:07 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.4 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 632771E79C for ; Wed, 20 Oct 2021 14:56:07 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CC5CE3857C7F for ; Wed, 20 Oct 2021 18:56:06 +0000 (GMT) Received: from gateway33.websitewelcome.com (gateway33.websitewelcome.com [192.185.146.85]) by sourceware.org (Postfix) with ESMTPS id 1D3043857C5D for ; Wed, 20 Oct 2021 18:55:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1D3043857C5D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tromey.com Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway33.websitewelcome.com (Postfix) with ESMTP id 218151E383 for ; Wed, 20 Oct 2021 13:54:00 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id dGitm1WgVgm2UdGitmu0IB; Wed, 20 Oct 2021 13:53:59 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=8vo33+mpUbv2shv8FHejKImMQqv1/edfNlxV05y/hCw=; b=rRCH4tLXmb4b7oV5jCTeeqAdCn YywQkcLHRc5a56OVRi6NBSPkO/0NyEmfWf+QHbDVVewNLnIUkRLepoG7WQAwkbV+AaOVL1TxlLHdz MsqRM/ZBD5LA48LkOL5yOeiFB; Received: from 174-16-0-219.hlrn.qwest.net ([174.16.0.219]:54024 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mdGis-001cqC-Ux; Wed, 20 Oct 2021 12:53:59 -0600 From: Tom Tromey To: Tom de Vries via Gdb-patches Subject: Re: [PATCH][gdb] Make execute_command_to_string return string on throw References: <20210911120202.GA16898@delia.home> <2f2ce317-ae71-88b8-4b84-5eead84c376d@simark.ca> X-Attribution: Tom Date: Wed, 20 Oct 2021 12:53:58 -0600 In-Reply-To: (Tom de Vries via Gdb-patches's message of "Thu, 7 Oct 2021 18:15:19 +0200") Message-ID: <87a6j3v86x.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.0.219 X-Source-L: No X-Exim-ID: 1mdGis-001cqC-Ux X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-0-219.hlrn.qwest.net (murgatroyd) [174.16.0.219]:54024 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Simon Marchi Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" >> The code LGTM, but could you write / update a test for this? Tom> The patch "[gdb/testsuite] Reimplement gdb.gdb/python-interrupts.exp as Tom> unittest" uses this. It checks the output of a command that is also Tom> throwing a "Error while executing Python code". FWIW the new self-test fails for me: (gdb) maint selftest python Running selftest python. 5 Self test failed: self-test failed at ../../binutils-gdb/gdb/python/python.c:1932 Ran 1 unit tests, 1 failed thanks, Tom