Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Gopi Kumar Bulusu <gopi@sankhya.com>
Cc: Tom de Vries <tdevries@suse.de>,  Simon Marchi <simark@simark.ca>,
	gdb-patches@sourceware.org
Subject: Re: [PATCH v2 ] MicroBlaze: Add microblaze_get_next_pcs
Date: Fri, 05 Sep 2025 07:24:20 -0600	[thread overview]
Message-ID: <87a539rq0r.fsf@tromey.com> (raw)
In-Reply-To: <CAL1P33yVRHB8Bs0AfAegE22HPOfs5Ej62NmR9FRVpUUT2UT+0w@mail.gmail.com> (Gopi Kumar Bulusu's message of "Fri, 5 Sep 2025 14:57:36 +0530")

>  This caused a buildbreaker on arm-linux with --enable-targets=all and 
>  --enable-64-bit-bfd.

> reverted commit c6df5d79aac5c4a77c06314fd26c837470360f70

Reverting seems a little heavy-handed for what looks like a pretty
simple fix.

FWIW in gdb, printing a CORE_ADDR is typically done with
core_addr_to_string or core_addr_to_string_nz.  Then in a printf, "%s"
is used.  E.g.:

    aarch64_debug_printf ("prologue analysis gave up "
                          "addr=%s opcode=0x%x (orr x register)",
                          core_addr_to_string_nz (start), insn);

Tom

  reply	other threads:[~2025-09-05 13:25 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-12  5:30 [PATCH] MicroBlaze: Add microblaze_software_single_step Gopi Kumar Bulusu
2025-08-13 20:11 ` Simon Marchi
2025-08-14 10:28   ` Gopi Kumar Bulusu
2025-09-02 12:27     ` [PATCH v2 ] MicroBlaze: Add microblaze_get_next_pcs Gopi Kumar Bulusu
2025-09-03 17:57       ` Simon Marchi
2025-09-03 18:02         ` Michael Eager
2025-09-04 11:43           ` Gopi Kumar Bulusu
2025-09-04 11:40         ` Gopi Kumar Bulusu
2025-09-05  9:29         ` Tom de Vries
2025-09-05  9:27           ` Gopi Kumar Bulusu
2025-09-05 13:24             ` Tom Tromey [this message]
2025-09-05 13:29               ` Gopi Kumar Bulusu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a539rq0r.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=gopi@sankhya.com \
    --cc=simark@simark.ca \
    --cc=tdevries@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox