Re: [PATCH] test: basename filenames in dwarf2 frame checks

[Andrew Burgess <aburgess@redhat.com>]

Bratislav Filipovic <bfilipov@amd.com> writes:

> Some gdb.dwarf2 tests match the output of commands like frame and
> expect to see locations printed as fission-base.c:LINE (no directory
> prefix).  When the test programs are built with clang as CC_FOR_TARGET,
> GDB can print an absolute source path instead, causing FAILs.

Thanks for taking a look at this, it's always nice to see tests being
improved like this.

This is fine, with two minor nits fixed...

>
> diff --git a/gdb/testsuite/gdb.dwarf2/dw2-undefined-ret-addr.exp b/gdb/testsuite/gdb.dwarf2/dw2-undefined-ret-addr.exp
> index 32ddaf4a..5b47c84c 100644
> --- a/gdb/testsuite/gdb.dwarf2/dw2-undefined-ret-addr.exp
> +++ b/gdb/testsuite/gdb.dwarf2/dw2-undefined-ret-addr.exp
> @@ -30,6 +30,11 @@ if {![runto "stop_frame"]} {
>      return -1
>  }
>  
> +# If test is compiled with clang, GDB would display absolute path
> +# This command keeps output consistent across toolchains.

This comment needs to be one complete sentence (add a comma after
'path', and change 'This' to 'this'), or two sentences (add a full stop
after 'path').

> +
> +gdb_test_no_output "set filename-display basename"
> +
>  # stop_frame should be the outermost frame.
>  
>  # Check that backtrace shows only frame #0.
> diff --git a/gdb/testsuite/gdb.dwarf2/fission-base.exp b/gdb/testsuite/gdb.dwarf2/fission-base.exp
> index 035fe731..a73cab48 100644
> --- a/gdb/testsuite/gdb.dwarf2/fission-base.exp
> +++ b/gdb/testsuite/gdb.dwarf2/fission-base.exp
> @@ -46,6 +46,11 @@ if {![runto_main]} {
>  gdb_test "ptype main" "type = int \\(\\)"
>  gdb_test "ptype func" "type = int \\(int\\)"
>  
> +# If test is compiled with clang, GDB would display absolute path
> +# This command keeps output consistent across toolchains.

Same issue here.

With both of those fixed:

Approved-By: Andrew Burgess <aburgess@redhat.com>

thanks,
Andrew