From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 4WqPGvZAzmlBzAMAWB0awg (envelope-from ) for ; Thu, 02 Apr 2026 06:12:06 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=KWvaY+5P; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 5B95F1E04F; Thu, 02 Apr 2026 06:12:06 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id D4E211E04F for ; Thu, 02 Apr 2026 06:12:05 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 24A964BA23E5 for ; Thu, 2 Apr 2026 10:12:04 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 24A964BA23E5 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=KWvaY+5P Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id C6FA94BA23F2 for ; Thu, 2 Apr 2026 10:11:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C6FA94BA23F2 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C6FA94BA23F2 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1775124698; cv=none; b=lGkq4dhZ9GdMb5UsH/wHLfj2l8KNGthhqrJohrijBfEjMnLvwVawco3Ng2HOxIuhFpMahGwCPa0bQ0Cr1wefn503X84rcyNOa08tiufHkexp6efvh7oJNcFJYMoizDzXq6r/fjkS6pngMfFN+1KsT8qgeVvlxgPT6tjHkUyIbzM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1775124698; c=relaxed/simple; bh=fVwhyHWilV+YMvQR1bOOAThF+Zym1f+rz8LlGUVGxRk=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=MiSVkXf7Jfh18XFvl2waAa+M98iI3/xkBt3uItT3vC9dAh1zkbQmWyLTv6tCdih+ecKrrXTNkPw4UutNXgwgJB7uRwr6xy/KMLDFrHBugbXY9UqDfBhBxl/15mvcn12i6J6fbHT0Uf40foevUiMYBKmO8kV0DJiTE67IovdFLL8= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C6FA94BA23F2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1775124698; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Uv+qe3nPGJ1q4b4EBwr7VuFw8njl5eZLpmSpzhhjaak=; b=KWvaY+5PCa7bsZevsLRII3pJPhxMscrcMnTayYjMHLvPkKYFB29HrMNVaH9meOSrtIaJa+ 8+HtqN9rCTCkCF1/FGVacu5gOMtG4czm1965Tjp/ONMWCuRPAZdGTFbdyirlFH2AAJFcIc pawuqVBHScTL9IAjgQV5JusGgYYwylc= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-683-sIZJ0fxkNtqPAb1tEBJdWA-1; Thu, 02 Apr 2026 06:11:37 -0400 X-MC-Unique: sIZJ0fxkNtqPAb1tEBJdWA-1 X-Mimecast-MFC-AGG-ID: sIZJ0fxkNtqPAb1tEBJdWA_1775124696 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-487219e0800so4487005e9.2 for ; Thu, 02 Apr 2026 03:11:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775124696; x=1775729496; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Uv+qe3nPGJ1q4b4EBwr7VuFw8njl5eZLpmSpzhhjaak=; b=SESUYhAtCHiX1Q8ZUlBejNuSub1r9lwFC7ImGhYY5fFp7HgPi6um4Gf9FCxhUQT+kM I5vOQzRBjpMfWRUQ4jaWqA1FfMOWnchWQDtzSBaibkkVT16KI5MObTLa7ZfLhBDPEzOr bZFOsnzULHLUwFgudHwLFHtvqT5qq5tiB/zXQYpr9wlVEMF4HOK0wFKnUEHTr/9EI27a +6fZzbrTwUU9OCbErmSQGqgi1SznwzFNvauctrQhMfHQB0nQyqTHSQTHAvElcihhoDtb 1MStKryXk2v1hacZQKDD0gxJHynrsIyUadwEI475S8Dz3hTpKbnEogYEq66otoll9WBG 3WTQ== X-Forwarded-Encrypted: i=1; AJvYcCXItXEeFKTU/NoigUMtCsQ9Vp/GhrRwF8q4y8JW330qFT8e8ftJAfrMVXXGRioVaau88FdIKVt75RAwag==@sourceware.org X-Gm-Message-State: AOJu0YyKd32m+hJLFzg/VxtOEonK/ui80c640vawPcOZrotCZtj2XVDP qM0cX2GQdMW0jfHsS3rZJOqUk2uswDQyOTR3aFK2B9KGdsASRZlAlABrozNZXNK54xZPtZQ0hUG JVT+YtuJtJg3dYTnGyGk2JDqJySRIb19VeZ7PCOiUPKR4NdBw4rIVmvuqs4cyODYPGA13yFk= X-Gm-Gg: ATEYQzxokDvZPdOstlkZpnwBtm3R7SrwwAcmKTB1XbVI3t+HB8FTEo4Mz+byRyO0pxy XKveNo0eY+MuxVaUR5WyGLM1G3XLMcWqGX6ldaKbzy3l0ZgnhSq/sk3F27O2HYXhy5FJ7aj1JzQ xswd+mK7YSLKfgaD3aMX9oN9NBSaSMhHho5Z1+bsx6cOzI0rYz+1efdeQMVCNiLtbnVitkvaZWi 8qosygUULmPEkN9OrhWpw+wM/3SJkB0smrXEY99fa6EbnzE845SKrc28nHWjSEfNm2DvmyLkO0T J34dxKJHkeu4r1ljtotEiX3HYhePFC2myZPUZ+RjZ0M1TMVJy63pDgV3saMFjeXtXZV6E7KSJre g0DYCLrNnXXXuYZCK X-Received: by 2002:a05:600c:8488:b0:485:6e40:5584 with SMTP id 5b1f17b1804b1-48883568434mr128881345e9.6.1775124695758; Thu, 02 Apr 2026 03:11:35 -0700 (PDT) X-Received: by 2002:a05:600c:8488:b0:485:6e40:5584 with SMTP id 5b1f17b1804b1-48883568434mr128880915e9.6.1775124695333; Thu, 02 Apr 2026 03:11:35 -0700 (PDT) Received: from localhost ([31.111.84.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4887adc5690sm109566365e9.2.2026.04.02.03.11.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Apr 2026 03:11:34 -0700 (PDT) From: Andrew Burgess To: Bratislav Filipovic , gdb-patches@sourceware.org Cc: simon.marchi@efficios.com, Bratislav Filipovic Subject: Re: [PATCH] test: basename filenames in dwarf2 frame checks In-Reply-To: <20260325163234.3377436-1-bfilipov@amd.com> References: <20260325163234.3377436-1-bfilipov@amd.com> Date: Thu, 02 Apr 2026 11:11:34 +0100 Message-ID: <87a4vl659l.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: NBpAsZdKxHEbB7vpX_BbzjhEFQnz6i_rdFc49Faeoq0_1775124696 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Bratislav Filipovic writes: > Some gdb.dwarf2 tests match the output of commands like frame and > expect to see locations printed as fission-base.c:LINE (no directory > prefix). When the test programs are built with clang as CC_FOR_TARGET, > GDB can print an absolute source path instead, causing FAILs. Thanks for taking a look at this, it's always nice to see tests being improved like this. This is fine, with two minor nits fixed... > > diff --git a/gdb/testsuite/gdb.dwarf2/dw2-undefined-ret-addr.exp b/gdb/testsuite/gdb.dwarf2/dw2-undefined-ret-addr.exp > index 32ddaf4a..5b47c84c 100644 > --- a/gdb/testsuite/gdb.dwarf2/dw2-undefined-ret-addr.exp > +++ b/gdb/testsuite/gdb.dwarf2/dw2-undefined-ret-addr.exp > @@ -30,6 +30,11 @@ if {![runto "stop_frame"]} { > return -1 > } > > +# If test is compiled with clang, GDB would display absolute path > +# This command keeps output consistent across toolchains. This comment needs to be one complete sentence (add a comma after 'path', and change 'This' to 'this'), or two sentences (add a full stop after 'path'). > + > +gdb_test_no_output "set filename-display basename" > + > # stop_frame should be the outermost frame. > > # Check that backtrace shows only frame #0. > diff --git a/gdb/testsuite/gdb.dwarf2/fission-base.exp b/gdb/testsuite/gdb.dwarf2/fission-base.exp > index 035fe731..a73cab48 100644 > --- a/gdb/testsuite/gdb.dwarf2/fission-base.exp > +++ b/gdb/testsuite/gdb.dwarf2/fission-base.exp > @@ -46,6 +46,11 @@ if {![runto_main]} { > gdb_test "ptype main" "type = int \\(\\)" > gdb_test "ptype func" "type = int \\(int\\)" > > +# If test is compiled with clang, GDB would display absolute path > +# This command keeps output consistent across toolchains. Same issue here. With both of those fixed: Approved-By: Andrew Burgess thanks, Andrew