From: Tom Tromey <tom@tromey.com>
To: Tom de Vries <tdevries@suse.de>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 01/12] [gdb] Use using instead of typedef some more (part 1)
Date: Fri, 26 Jun 2026 09:40:31 -0600 [thread overview]
Message-ID: <87a4shwbrk.fsf@tromey.com> (raw)
In-Reply-To: <20260616062257.3164438-2-tdevries@suse.de> (Tom de Vries's message of "Tue, 16 Jun 2026 08:22:46 +0200")
>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
Tom> diff --git a/gdb/arc-linux-tdep.c b/gdb/arc-linux-tdep.c
Tom> index 572b39b27d4..51a7c4e1957 100644
Tom> --- a/gdb/arc-linux-tdep.c
Tom> +++ b/gdb/arc-linux-tdep.c
Tom> @@ -715,7 +715,7 @@ arc_linux_init_osabi (struct gdbarch_info info, struct gdbarch *gdbarch)
Tom> /* If we are using Linux, we have in uClibc
Tom> (libc/sysdeps/linux/arc/bits/setjmp.h):
Tom> - typedef int __jmp_buf[13+1+1+1]; //r13-r25, fp, sp, blink
Tom> + using __jmp_buf = int[13+1+1+1]; //r13-r25, fp, sp, blink
Tom> Where "blink" is a stored PC of a caller function.
Tom> */
This rewrite seems strange since it's a comment quoting a header that
does not actually say this.
Tom> diff --git a/gdb/i386-sol2-nat.c b/gdb/i386-sol2-nat.c
Tom> index 5b8b53e4605..b64ffef639b 100644
Tom> --- a/gdb/i386-sol2-nat.c
Tom> +++ b/gdb/i386-sol2-nat.c
Tom> @@ -137,7 +137,7 @@ fill_fpregset (const struct regcache *regcache,
Tom> different for each set of registers. For the i386 for example, the
Tom> general-purpose register set is typically defined by:
Tom> - typedef int gregset_t[19]; (in <sys/regset.h>)
Tom> + using gregset_t = int[19]; (in <sys/regset.h>)
Tom> #define GS 0 (in <sys/reg.h>)
Tom> #define FS 1
Likewise here.
Other than these this looks good to me though.
Tom
next prev parent reply other threads:[~2026-06-26 15:41 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-16 6:22 [PATCH 00/12] [gdb] Use using instead of typedef some more Tom de Vries
2026-06-16 6:22 ` [PATCH 01/12] [gdb] Use using instead of typedef some more (part 1) Tom de Vries
2026-06-26 15:40 ` Tom Tromey [this message]
2026-06-16 6:22 ` [PATCH 02/12] [gdb] Use using instead of typedef some more (part 2) Tom de Vries
2026-06-16 6:22 ` [PATCH 03/12] [gdb] Use using instead of typedef some more (part 3) Tom de Vries
2026-06-26 15:49 ` Tom Tromey
2026-06-16 6:22 ` [PATCH 04/12] [gdb] Convert function pointer typedefs to using Tom de Vries
2026-06-16 6:22 ` [PATCH 05/12] [gdb] Convert template " Tom de Vries
2026-06-16 6:22 ` [PATCH 06/12] [gdb] Convert function " Tom de Vries
2026-06-16 6:22 ` [PATCH 07/12] [gdb] Fix redundant struct typedefs Tom de Vries
2026-06-16 6:22 ` [PATCH 08/12] [gdb] Convert anonymous " Tom de Vries
2026-06-16 6:22 ` [PATCH 09/12] [gdb] Convert typedef of named struct Tom de Vries
2026-06-26 16:04 ` Tom Tromey
2026-06-16 6:22 ` [PATCH 10/12] [gdb] convert struct pointer typedefs Tom de Vries
2026-06-16 6:22 ` [PATCH 11/12] [gdb] Convert typedef on separate line Tom de Vries
2026-06-16 6:22 ` [PATCH 12/12] [gdb] Use using in compat_x32_clock_t typedef Tom de Vries
2026-06-26 16:05 ` [PATCH 00/12] [gdb] Use using instead of typedef some more Tom Tromey
2026-07-13 13:07 ` Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a4shwbrk.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox