From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 4eYwJo+dPmqFZRkAWB0awg (envelope-from ) for ; Fri, 26 Jun 2026 11:41:03 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=kfazn5S6; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 8E49D1E098; Fri, 26 Jun 2026 11:41:03 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 056E91E024 for ; Fri, 26 Jun 2026 11:41:03 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 781924BA2E2D for ; Fri, 26 Jun 2026 15:41:02 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 781924BA2E2D Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=kfazn5S6 Received: from omta38.uswest2.a.cloudfilter.net (omta38.uswest2.a.cloudfilter.net [35.89.44.37]) by sourceware.org (Postfix) with ESMTPS id A9F974BA2E08 for ; Fri, 26 Jun 2026 15:40:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A9F974BA2E08 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A9F974BA2E08 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=35.89.44.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1782488436; cv=none; b=MbkS1F8sPWW5lsQrJ+o7mg+0yi3GRaPQYhYF3VFagrGVEud6cfR78pxl6R5LvevdZ/UogwZn+8XfrKz61Zca9JxLgGelEP/DVNJ6UzXO/IfPWYkq1zE0OdX5/vN/5grIfc5p6tkT4gtPKEHKzCxJNOFp7DpKAPxooIXn/kaf4+Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1782488436; c=relaxed/simple; bh=tZtige30vnJ3dJN9gw5ma2dwEGDbmOltnVUYD0iJxUY=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=JW+t30KXteKQNWQiGKIgLm5jjqIzB4FVymdRAlr0y54V7htciesl2zQ8AMlWgmfRUebbWNv0E4nbc7AxlzWYSvFQcXTOMGVLe2VfAMueEv4lT7n/RQAOicMeZDT/kdzcdzT48w2xLiOn7lUG5xY2OMHVHn+2oCxBHGQdPF96zlw= ARC-Authentication-Results: i=1; sourceware.org; dkim=policy (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=kfazn5S6 reason="signing key too small" DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A9F974BA2E08 Received: from eig-obgw-5004b.ext.cloudfilter.net ([10.0.29.208]) by cmsmtp with ESMTPS id d82OwxhUhMFEgd8fTwr61C; Fri, 26 Jun 2026 15:40:35 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id d8fRw691fHMAqd8fRwGx0C; Fri, 26 Jun 2026 15:40:33 +0000 X-Authority-Analysis: v=2.4 cv=WMt/XmsR c=1 sm=1 tr=0 ts=6a3e9d73 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=FelO9ux0wxsA:10 a=ItBw4LHWJt0A:10 a=Ei32unW9FGSjc5LrPrcA:9 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=wnkgCnaYRurpq9SSFEOua4cRvYmH2AKuox0v4an+Mzs=; b=kfazn5S62FPoIoUGNaibTeRI2v Mz+N/3L/zba1u762JoJHAraDJfN5YAmTDOFgJ/nliHTbj3JtDMmTfk3I22wLa4bvtBfM6GLJs4ZB6 oE0x/YgyS/LeYCZoeU4hmII+C; Received: from 75-166-225-82.hlrn.qwest.net ([75.166.225.82]:33194 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.99.2) (envelope-from ) id 1wd8fQ-00000000m9Y-41Zn; Fri, 26 Jun 2026 09:40:33 -0600 From: Tom Tromey To: Tom de Vries Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 01/12] [gdb] Use using instead of typedef some more (part 1) In-Reply-To: <20260616062257.3164438-2-tdevries@suse.de> (Tom de Vries's message of "Tue, 16 Jun 2026 08:22:46 +0200") References: <20260616062257.3164438-1-tdevries@suse.de> <20260616062257.3164438-2-tdevries@suse.de> X-Attribution: Tom Date: Fri, 26 Jun 2026 09:40:31 -0600 Message-ID: <87a4shwbrk.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.225.82 X-Source-L: No X-Exim-ID: 1wd8fQ-00000000m9Y-41Zn X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-225-82.hlrn.qwest.net (bapiya) [75.166.225.82]:33194 X-Source-Auth: tom+tromey.com X-Email-Count: 9 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfOtIf1rhY/mw0hxEhe3IEsOD3UMEmuktjvHC3YNuPtr1T3o3wbNFLe+D0h4Y+cY0N8Nx1uiF2eh09aEQuMdCQlsWHbt7juljTvNVcDIuUi29l0kfz5ry +63BvVuWlWfCTZ4mRB3dg1B2qT5UFaCX9pQL+hF7tBmb/bYLbHrvlQSY5P1wSh4JMMrrZRzl+tPh+Hx2hZzk/enhyCeefoU3dd0= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Tom" == Tom de Vries writes: Tom> diff --git a/gdb/arc-linux-tdep.c b/gdb/arc-linux-tdep.c Tom> index 572b39b27d4..51a7c4e1957 100644 Tom> --- a/gdb/arc-linux-tdep.c Tom> +++ b/gdb/arc-linux-tdep.c Tom> @@ -715,7 +715,7 @@ arc_linux_init_osabi (struct gdbarch_info info, struct gdbarch *gdbarch) Tom> /* If we are using Linux, we have in uClibc Tom> (libc/sysdeps/linux/arc/bits/setjmp.h): Tom> - typedef int __jmp_buf[13+1+1+1]; //r13-r25, fp, sp, blink Tom> + using __jmp_buf = int[13+1+1+1]; //r13-r25, fp, sp, blink Tom> Where "blink" is a stored PC of a caller function. Tom> */ This rewrite seems strange since it's a comment quoting a header that does not actually say this. Tom> diff --git a/gdb/i386-sol2-nat.c b/gdb/i386-sol2-nat.c Tom> index 5b8b53e4605..b64ffef639b 100644 Tom> --- a/gdb/i386-sol2-nat.c Tom> +++ b/gdb/i386-sol2-nat.c Tom> @@ -137,7 +137,7 @@ fill_fpregset (const struct regcache *regcache, Tom> different for each set of registers. For the i386 for example, the Tom> general-purpose register set is typically defined by: Tom> - typedef int gregset_t[19]; (in ) Tom> + using gregset_t = int[19]; (in ) Tom> #define GS 0 (in ) Tom> #define FS 1 Likewise here. Other than these this looks good to me though. Tom