From: Tom Tromey <tromey@adacore.com>
To: Tom de Vries <tdevries@suse.de>
Cc: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix type of imported variable for arraydim.exp
Date: Mon, 03 Aug 2026 07:29:32 -0600 [thread overview]
Message-ID: <87a4r3qqmb.fsf@tromey.com> (raw)
In-Reply-To: <2d4071c4-3ed5-4ee0-9391-a421905fcb13@suse.de> (Tom de Vries's message of "Fri, 31 Jul 2026 14:01:54 +0200")
>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
Tom> On 7/30/26 6:59 PM, Tom Tromey wrote:
>> The test code for gdb.ada/arraydim.exp imports a variable using a
>> dummy type. Then the test tries to print the type of this variable.
>> This works ok with GCC, because the import is emitted as a
>> declaration; but this fails with gnat-llvm, where a definition is
>> emitted.
>> This seems to be a test bug to me. This patch fixes the problem by
>> using the correct type here.
Tom> Do I understand it correctly that there are two (independent) issues:
Tom> - decl vs def: fixed in arraydim.exp
Tom> - dummy type vs correct type: fixed in arraydim/foo.adb
Tom> ?
More or less. If the compiler emits a declaration in the DWARF, the
test works ok. This is the GCC case. But gnat-llvm emits a definition
instead, which seems completely valid to me; but since the type is wrong
the test fails.
Tom
prev parent reply other threads:[~2026-08-03 13:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-30 16:59 Tom Tromey
2026-07-31 12:01 ` Tom de Vries
2026-08-03 13:29 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a4r3qqmb.fsf@tromey.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox