From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id kY3+NdmXcGoHhwIAWB0awg (envelope-from ) for ; Mon, 03 Aug 2026 09:30:01 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=lXterS21; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 993AA1E099; Mon, 03 Aug 2026 09:30:01 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 61C831E099 for ; Mon, 03 Aug 2026 09:30:00 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2FF464BAE7F3 for ; Mon, 3 Aug 2026 13:29:59 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2FF464BAE7F3 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=lXterS21 Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) by sourceware.org (Postfix) with ESMTPS id A4E2E4BA23F3 for ; Mon, 3 Aug 2026 13:29:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A4E2E4BA23F3 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A4E2E4BA23F3 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::62b ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1785763776; cv=none; b=dOBfLYRuHCWZa2vxt6zigjUcOZizzkpO+7rFlESI6DvUNI9FqLvZWAAtYQnWoPiSEFe5n2l3HOuDjgIOFdH5OyRbEtEWdOWwUk59v0ft7put5JBrk3MZ5hDEDlQgjp7yk3OS1jR3dBLITQ3kdeVxYjO5ONDNlmjhpauqrNm/IsY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1785763776; c=relaxed/simple; bh=cLDzIhZAm5dheRO5iwayxGtEx8VTHMRS+eeN+AVgrwY=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=bpTg6DBnIkDA7F7DB9e4LFX9dLOPzbcYUbIwwLQmBV4nZS98b/zWVqpsmha8xETL5ob9NeuK+Afhjx8aNAJbyuxHbwlEin7LxVCnI3eFpXdhIkFokODKvP4QwxjIsrN5cELfGAXMAub4AB+OoT/7CBS7X9GJvO2Ew6LnlOxrq7w= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=lXterS21 DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A4E2E4BA23F3 Received: by mail-ej1-x62b.google.com with SMTP id a640c23a62f3a-c2020421077so35346166b.3 for ; Mon, 03 Aug 2026 06:29:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1785763775; x=1786368575; darn=sourceware.org; h=content-type:mime-version:user-agent:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=Rn28glRuSEel+874+tv/ro7EzgWPsAmfVgKMbFkMmYs=; b=lXterS21meZrNeL9BUpYwd6kPgbUC/95pA1bA9KTwK+bN11yAuqEFg7F8ktZ3bVu5K 3PDi3qjkFpEJZZMggLp8X9itGcH2E/BU8HNeQlYdS/eO0MAc3GFW/YhlK67OcwtF2ztR hV3wlYONH+kGnqM6ugteGJOcsHctNh/uES/bXx7kTMAGfXx+rZA/Qlx3XuKUQ7S63GJ3 eZu/P0XjYIt/mPQnqm/mVHgpuwkY++VSj6UU9HhqDwR15Q5qWrzqFaMfO9PkiAYTk5Aj av7bg7q5lT6jkyVjO1aERG+3z9kERBzntF6VmGALPWndCU89zcs10a6wPOxbTY0oIvw8 b4NQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785763775; x=1786368575; h=content-type:mime-version:user-agent:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to:content-type; bh=Rn28glRuSEel+874+tv/ro7EzgWPsAmfVgKMbFkMmYs=; b=Ck9JOHVjzR0xxrST0V6szuFPbCU4edH6aWEtF1eEAMsvymEuWiWBkHCy/RtBhD0LJm sy7yM9ALXODAGGY/d4zzoxEN+DP/ETd16QsqHu8X7nAhCP30R4GetSRNhFubh7XhF22K Pt2wxUv0urJhFfkaPqElcLTlkYfy3VuXbaX399s8YxudS2/k7mrwyqwWLGI24L0G3QSA mTqHdGeVYQCRrYvdcIbZDxHLT+YFtUoor9vs9AaW6HgWS6lEQitTKLfU9vVoldlZ8QCn NgBY11Oq1aOY+w3ZzZ1sd2sjjO5HPe9uFrOlSC2uNcS6BDnzEiCENNi6/oiKYZrt+hzZ G6Cw== X-Forwarded-Encrypted: i=1; AHgh+RpukR7bLnFnOX0R6h3mLhyeovBGiK2pWhJz6S4uR2anxT0MwcppbBGdjs5rtkR9GKZpO4GsMJZDChxaJg==@sourceware.org X-Gm-Message-State: AOJu0Yz3pfyIEUOTdmjRDd9/PH7qKnsas8BnidpuszRNWmlZejA3puiL ErAl+7brMYZownGmbeBKa/Hm7ozTxDuoSe9Kun1pXJrwiT/8u9JfO2Fea0OohMbFzw== X-Gm-Gg: AR+sD11DGEu6sYC2sefMymGBNgPt0W3/5oTZfV6EI02SSM6whtlnhw7jvV97EAg3hdc EPJRasMCoMS1D7EGG6EvYfXKwyiBkfRrLhSzBeG/Wa69fCcTXFCsGMqNq/yesybcLjw7q10eGD/ VXx2j2l7aTRbalQ4bSka3ECLkS/oEszwGwOVTwtVdP4hxL0kVCmagqoq6KCL1OKRD+10SvN274L g7Dzfo2KmkMTKRcIo1zRs5iwfURqC0+YU83yO0Oghsi3cuH0/uEYn02l86NMk931xuk7akEXYf8 9nZ9Vz5+KMyjau/f2PNP+6grB5ABHQFdvAYJeX9Ha+vrMXB6PqTNmawGzIPbI97EqmORPuV05x8 LN9EbHYIQzhzD5zsgvSVMl221iWLVWGCllGGMDT9tf0OhkQo1TXWy2T1/OzRKbCK0xdsNZoxxAS 0qkI7u4xjm1S9AWb7hO0FJ5clP4Qf8uA0AamqmTJG6k49zztxq2hJBKgki+iI60gcn7ppD/Pz5w ueXfbASxiBRwXgo27I= X-Received: by 2002:a17:906:dd9:b0:c1c:4afd:8d8c with SMTP id a640c23a62f3a-c1fe7f67f8bmr525400966b.14.1785763775508; Mon, 03 Aug 2026 06:29:35 -0700 (PDT) Received: from bapiya (75-166-225-82.hlrn.qwest.net. [75.166.225.82]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c1fd3c9e5adsm553852466b.23.2026.08.03.06.29.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Aug 2026 06:29:34 -0700 (PDT) From: Tom Tromey To: Tom de Vries Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH] Fix type of imported variable for arraydim.exp In-Reply-To: <2d4071c4-3ed5-4ee0-9391-a421905fcb13@suse.de> (Tom de Vries's message of "Fri, 31 Jul 2026 14:01:54 +0200") References: <20260730165933.2515411-1-tromey@adacore.com> <2d4071c4-3ed5-4ee0-9391-a421905fcb13@suse.de> X-Attribution: Tom Date: Mon, 03 Aug 2026 07:29:32 -0600 Message-ID: <87a4r3qqmb.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Tom" == Tom de Vries writes: Tom> On 7/30/26 6:59 PM, Tom Tromey wrote: >> The test code for gdb.ada/arraydim.exp imports a variable using a >> dummy type. Then the test tries to print the type of this variable. >> This works ok with GCC, because the import is emitted as a >> declaration; but this fails with gnat-llvm, where a definition is >> emitted. >> This seems to be a test bug to me. This patch fixes the problem by >> using the correct type here. Tom> Do I understand it correctly that there are two (independent) issues: Tom> - decl vs def: fixed in arraydim.exp Tom> - dummy type vs correct type: fixed in arraydim/foo.adb Tom> ? More or less. If the compiler emits a declaration in the DWARF, the test works ok. This is the GCC case. But gnat-llvm emits a definition instead, which seems completely valid to me; but since the type is wrong the test fails. Tom