From: Tom Tromey <tromey@redhat.com>
To: dje@google.com (Doug Evans)
Cc: gdb-patches@sourceware.org, ccoutant@google.com, saugustine@google.com
Subject: Re: [RFA 2/3] Initial Fission support, rewrite DIE reading
Date: Thu, 26 Apr 2012 21:52:00 -0000 [thread overview]
Message-ID: <878vhi6vq1.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20120418185511.0AED52461AF@ruffy.mtv.corp.google.com> (Doug Evans's message of "Wed, 18 Apr 2012 11:55:10 -0700 (PDT)")
>>>>> "Doug" == Doug Evans <dje@google.com> writes:
Doug> This is the second patch in the Fission series and an updated
Doug> version of what I posted earlier:
Doug> http://sourceware.org/ml/gdb-patches/2012-04/msg00337.html
Doug> Ok to commit?
I found the patch pretty hard to read.
It looked like you moved some functions around, making it harder to
understand as a patch.
Anyway, nothing really stuck out for me. I think it is ok.
Tom
next prev parent reply other threads:[~2012-04-26 21:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-18 18:58 Doug Evans
2012-04-25 14:58 ` Doug Evans
2012-04-26 21:52 ` Tom Tromey [this message]
2012-04-26 23:05 ` Doug Evans
2012-04-29 9:17 ` Crash regression for gdb.ada/*.exp [Re: [RFA 2/3] Initial Fission support, rewrite DIE reading] Jan Kratochvil
2012-04-30 1:37 ` Doug Evans
2012-04-30 2:05 ` Jan Kratochvil
2012-04-30 17:09 ` Doug Evans
2012-04-30 17:19 ` Jan Kratochvil
2012-04-30 18:09 ` Doug Evans
2012-05-02 23:19 ` Crash on new testcase gdb.dwarf2/pr13961.exp [Re: Crash regression for gdb.ada/*.exp] Jan Kratochvil
2012-05-03 6:54 ` Doug Evans
2012-07-19 8:17 ` Crash regression for gdb.ada/*.exp [Re: [RFA 2/3] Initial Fission support, rewrite DIE reading] Andreas Schwab
2012-07-19 16:18 ` dje
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878vhi6vq1.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=ccoutant@google.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=saugustine@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox