From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9138 invoked by alias); 26 Apr 2012 21:15:38 -0000 Received: (qmail 9126 invoked by uid 22791); 26 Apr 2012 21:15:37 -0000 X-SWARE-Spam-Status: No, hits=-6.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 26 Apr 2012 21:15:21 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q3QLFJ8o010566 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 26 Apr 2012 17:15:20 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q3QLFIku024921 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Thu, 26 Apr 2012 17:15:19 -0400 From: Tom Tromey To: dje@google.com (Doug Evans) Cc: gdb-patches@sourceware.org, ccoutant@google.com, saugustine@google.com Subject: Re: [RFA 2/3] Initial Fission support, rewrite DIE reading References: <20120418185511.0AED52461AF@ruffy.mtv.corp.google.com> Date: Thu, 26 Apr 2012 21:52:00 -0000 In-Reply-To: <20120418185511.0AED52461AF@ruffy.mtv.corp.google.com> (Doug Evans's message of "Wed, 18 Apr 2012 11:55:10 -0700 (PDT)") Message-ID: <878vhi6vq1.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.95 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-04/txt/msg00967.txt.bz2 >>>>> "Doug" == Doug Evans writes: Doug> This is the second patch in the Fission series and an updated Doug> version of what I posted earlier: Doug> http://sourceware.org/ml/gdb-patches/2012-04/msg00337.html Doug> Ok to commit? I found the patch pretty hard to read. It looked like you moved some functions around, making it harder to understand as a patch. Anyway, nothing really stuck out for me. I think it is ok. Tom