From: Tom Tromey <tromey@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Fix PR14617: New MI notification on tracepoint modified.
Date: Fri, 02 Nov 2012 14:42:00 -0000 [thread overview]
Message-ID: <878vakqd73.fsf@fleche.redhat.com> (raw)
In-Reply-To: <50936A39.8080804@codesourcery.com> (Yao Qi's message of "Fri, 2 Nov 2012 14:37:45 +0800")
>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:
Yao> Inspired by your comments, 'breakpoint-modified' notification has covered
Yao> tracepoint modification, which I didn't realize. This version is much
Yao> simpler because we can put tracepoint object to function
Yao> observer_notify_breakpoint_modified, and "pass" field appears in the
Yao> MI notification. On the other hand, existing observers
Yao> tracepoint_{created,deleted,modified} are useless, so they are removed
Yao> in this patch as well.
Yao> Regression tested on x86_64-linux. Is it OK?
It seems reasonable to me.
Ok.
Tom
next prev parent reply other threads:[~2012-11-02 14:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-18 10:36 Yao Qi
2012-10-18 17:33 ` Eli Zaretskii
2012-10-30 7:03 ` Yao Qi
2012-10-30 17:23 ` Eli Zaretskii
2012-11-01 20:27 ` Tom Tromey
2012-11-02 6:38 ` Yao Qi
2012-11-02 14:42 ` Tom Tromey [this message]
2012-11-02 15:17 ` Pedro Alves
2012-11-02 15:22 ` Yao Qi
2012-11-02 15:25 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878vakqd73.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox