From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8268 invoked by alias); 2 Nov 2012 14:42:06 -0000 Received: (qmail 8259 invoked by uid 22791); 2 Nov 2012 14:42:05 -0000 X-SWARE-Spam-Status: No, hits=-7.0 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 02 Nov 2012 14:41:56 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qA2EfsWO007800 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 2 Nov 2012 10:41:54 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id qA2Efq1i014389 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Fri, 2 Nov 2012 10:41:53 -0400 From: Tom Tromey To: Yao Qi Cc: Subject: Re: [PATCH] Fix PR14617: New MI notification on tracepoint modified. References: <1350556586-12800-1-git-send-email-yao@codesourcery.com> <87txt9qdbf.fsf@fleche.redhat.com> <50936A39.8080804@codesourcery.com> Date: Fri, 02 Nov 2012 14:42:00 -0000 In-Reply-To: <50936A39.8080804@codesourcery.com> (Yao Qi's message of "Fri, 2 Nov 2012 14:37:45 +0800") Message-ID: <878vakqd73.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-11/txt/msg00040.txt.bz2 >>>>> "Yao" == Yao Qi writes: Yao> Inspired by your comments, 'breakpoint-modified' notification has covered Yao> tracepoint modification, which I didn't realize. This version is much Yao> simpler because we can put tracepoint object to function Yao> observer_notify_breakpoint_modified, and "pass" field appears in the Yao> MI notification. On the other hand, existing observers Yao> tracepoint_{created,deleted,modified} are useless, so they are removed Yao> in this patch as well. Yao> Regression tested on x86_64-linux. Is it OK? It seems reasonable to me. Ok. Tom