From: Tom Tromey <tromey@redhat.com>
To: Hui Zhu <teawater@gmail.com>
Cc: gdb-patches ml <gdb-patches@sourceware.org>,
Hui Zhu <hui_zhu@mentor.com>
Subject: Re: [PATCH] Add fseek to ui-file
Date: Wed, 12 Dec 2012 15:38:00 -0000 [thread overview]
Message-ID: <878v939t6z.fsf@fleche.redhat.com> (raw)
In-Reply-To: <CANFwon066Z=cWcSKcyB0dT2yG0id67L5qhB0euTVsyeoQZgSeQ@mail.gmail.com> (Hui Zhu's message of "Wed, 12 Dec 2012 19:00:22 +0800")
>>>>> "Hui" == Hui Zhu <teawater@gmail.com> writes:
Hui> +static int
Hui> +null_file_fseek (struct ui_file *stream, long offset, int whence)
Hui> +{
Hui> + return 0;
Hui> +}
Why does this return success rather than error?
It seems strange to report success when nothing actually happens.
Hui> +typedef int (ui_file_fseek_ftype) (struct ui_file * stream, long offset,
Hui> + int whence);
Extra space after "*".
Hui> +extern int ui_file_fseek (struct ui_file * file, long offset, int whence);
Here too.
Tom
next prev parent reply other threads:[~2012-12-12 15:38 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-06 9:46 Hui Zhu
2012-12-06 21:48 ` Tom Tromey
2012-12-07 8:02 ` Hui Zhu
2012-12-07 9:56 ` Pedro Alves
2012-12-10 10:48 ` Hui Zhu
2012-12-10 19:54 ` Tom Tromey
2012-12-11 10:35 ` Pedro Alves
2012-12-11 14:35 ` Hui Zhu
2012-12-11 14:39 ` Pedro Alves
2012-12-11 14:58 ` Hui Zhu
2012-12-07 14:49 ` Tom Tromey
2012-12-10 10:57 ` Hui Zhu
2012-12-10 19:55 ` Tom Tromey
2012-12-11 7:22 ` Hui Zhu
2012-12-12 11:01 ` Hui Zhu
2012-12-12 15:38 ` Tom Tromey [this message]
2012-12-13 1:45 ` Hui Zhu
2012-12-14 19:18 ` Tom Tromey
2012-12-17 3:00 ` Hui Zhu
2012-12-17 20:04 ` Tom Tromey
2012-12-18 7:03 ` Hui Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878v939t6z.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=hui_zhu@mentor.com \
--cc=teawater@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox