From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-96920-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 2950 invoked by alias); 12 Dec 2012 15:38:39 -0000
Received: (qmail 2804 invoked by uid 22791); 12 Dec 2012 15:38:37 -0000
X-SWARE-Spam-Status: No, hits=-6.4 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 12 Dec 2012 15:38:32 +0000
Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qBCFcUwp029331	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Wed, 12 Dec 2012 10:38:30 -0500
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id qBCFcS8Z007919	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Wed, 12 Dec 2012 10:38:29 -0500
From: Tom Tromey <tromey@redhat.com>
To: Hui Zhu <teawater@gmail.com>
Cc: gdb-patches ml <gdb-patches@sourceware.org>, Hui Zhu <hui_zhu@mentor.com>
Subject: Re: [PATCH] Add fseek to ui-file
References: <CANFwon0Nv=Dk7-1kmxwjwv9zd-qoWUL18mpqH9vazRzBnkd10g@mail.gmail.com>	<87txryx36w.fsf@fleche.redhat.com>	<CANFwon31+VCzVWBvDLQedK0EGatd6XrRxaH1LbnHUtEKA91Ciw@mail.gmail.com>	<87lid9x6hl.fsf@fleche.redhat.com>	<CANFwon1PmXCeGNxJDCKpe+i+5L6CwZcJ-zC045S0CXiWHnepTg@mail.gmail.com>	<87vcc9el7d.fsf@fleche.redhat.com>	<CANFwon066Z=cWcSKcyB0dT2yG0id67L5qhB0euTVsyeoQZgSeQ@mail.gmail.com>
Date: Wed, 12 Dec 2012 15:38:00 -0000
In-Reply-To: <CANFwon066Z=cWcSKcyB0dT2yG0id67L5qhB0euTVsyeoQZgSeQ@mail.gmail.com>	(Hui Zhu's message of "Wed, 12 Dec 2012 19:00:22 +0800")
Message-ID: <878v939t6z.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.90 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-12/txt/msg00393.txt.bz2

>>>>> "Hui" == Hui Zhu <teawater@gmail.com> writes:

Hui> +static int
Hui> +null_file_fseek (struct ui_file *stream, long offset, int whence)
Hui> +{
Hui> +  return 0;
Hui> +}

Why does this return success rather than error?
It seems strange to report success when nothing actually happens.

Hui> +typedef int (ui_file_fseek_ftype) (struct ui_file * stream, long offset,
Hui> +				   int whence);

Extra space after "*".

Hui> +extern int ui_file_fseek (struct ui_file * file, long offset, int whence);

Here too.

Tom