From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simark@simark.ca>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 1/2] Remove munmap_listp_free_cleanup
Date: Mon, 17 Sep 2018 06:23:00 -0000 [thread overview]
Message-ID: <878t40od6j.fsf@tromey.com> (raw)
In-Reply-To: <04207066-48a5-b93e-540e-b6bfefb3f07b@simark.ca> (Simon Marchi's message of "Sun, 16 Sep 2018 21:37:37 -0400")
>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:
Simon> Not a big deal, but we might as well use a vector. The objects
Simon> are cheap to copy, so there's probably less overhead overall
Simon> (memory and time) to use a vector than a doubly linked list.
I made this change.
Simon> I was going to say:
Simon> 1. Why not use munmap_list as directly as field of setup_sections_data, instead
Simon> of a unique_ptr, and
Simon> 2. std::move it to the compile_module object.
Simon> But that would require C++ifying compile_module and probably
Simon> do_module_cleanup too, and that's perhaps a too big of a step for
Simon> this patch.
Yeah, that's why I didn't do it.
Tom
next prev parent reply other threads:[~2018-09-17 6:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-15 22:24 [PATCH 0/2] remove the remaining cleanups from gdb/compile Tom Tromey
2018-09-15 22:24 ` [PATCH 1/2] Remove munmap_listp_free_cleanup Tom Tromey
2018-09-17 1:37 ` Simon Marchi
2018-09-17 6:23 ` Tom Tromey [this message]
2018-09-17 10:58 ` Pedro Alves
2018-09-17 21:21 ` Tom Tromey
2018-09-18 14:19 ` Pedro Alves
2018-09-15 22:24 ` [PATCH 2/2] Remove remaining cleanups from compile-object-load.c Tom Tromey
2018-09-17 1:39 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878t40od6j.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox