From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 122451 invoked by alias); 17 Sep 2018 06:23:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 122303 invoked by uid 89); 17 Sep 2018 06:23:04 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:732 X-HELO: gateway30.websitewelcome.com Received: from gateway30.websitewelcome.com (HELO gateway30.websitewelcome.com) (192.185.179.30) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 17 Sep 2018 06:23:02 +0000 Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway30.websitewelcome.com (Postfix) with ESMTP id 75FA111AAD for ; Mon, 17 Sep 2018 01:23:01 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 1mw1guDZ7BcCX1mw1gJMYD; Mon, 17 Sep 2018 01:23:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=GVrSpZc6ppcxrm05ZdvF/BbhpR+1Y1e/R79ooEx9m/U=; b=OeNsOrB1Uds6V4JoTBWxoOnqoe KXrb6L1qgsqSIDAi/hsMd8j3BQcokgZS9JHgafMdqXGnvyGr1E2YfGsvu6oXYUXM/IX2+FeWsiIlZ i9WA9ympSsSOY+aruGFfjnJzA; Received: from 97-122-190-66.hlrn.qwest.net ([97.122.190.66]:49252 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1g1mw1-003L0w-5V; Mon, 17 Sep 2018 01:23:01 -0500 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 1/2] Remove munmap_listp_free_cleanup References: <20180915222411.24764-1-tom@tromey.com> <20180915222411.24764-2-tom@tromey.com> <04207066-48a5-b93e-540e-b6bfefb3f07b@simark.ca> Date: Mon, 17 Sep 2018 06:23:00 -0000 In-Reply-To: <04207066-48a5-b93e-540e-b6bfefb3f07b@simark.ca> (Simon Marchi's message of "Sun, 16 Sep 2018 21:37:37 -0400") Message-ID: <878t40od6j.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-09/txt/msg00559.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> Not a big deal, but we might as well use a vector. The objects Simon> are cheap to copy, so there's probably less overhead overall Simon> (memory and time) to use a vector than a doubly linked list. I made this change. Simon> I was going to say: Simon> 1. Why not use munmap_list as directly as field of setup_sections_data, instead Simon> of a unique_ptr, and Simon> 2. std::move it to the compile_module object. Simon> But that would require C++ifying compile_module and probably Simon> do_module_cleanup too, and that's perhaps a too big of a step for Simon> this patch. Yeah, that's why I didn't do it. Tom