Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Tom de Vries <tdevries@suse.de>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH][gdb] Fix heap-use-after-free in typename_concat
Date: Thu, 16 May 2019 18:53:00 -0000	[thread overview]
Message-ID: <878sv6w7si.fsf@tromey.com> (raw)
In-Reply-To: <20190503093124.GA27838@delia> (Tom de Vries's message of "Fri, 3	May 2019 11:31:26 +0200")

>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:

Tom> When running gdb using AddressSanitizer, and loading a cc1plus binary built
Tom> with profiledbootstrap and -flto, we run into a heap-use-after-free error:

Thanks for finding this.

Tom> +	{
Tom> +	  struct cu_partial_die_info res;
Tom> +	  res.pdi = pd;
Tom> +	  res.cu = cu;
Tom> +	  return res;
Tom> +	}

Can't this be just "return {pd, cu};"?

Tom> +  {
Tom> +    struct cu_partial_die_info res;
Tom> +    res.pdi = pd;
Tom> +    res.cu = per_cu->cu;
Tom> +    return res;
Tom> +  }

If so, another instance of it.

thanks,
Tom


  parent reply	other threads:[~2019-05-16 18:53 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-03  9:31 Tom de Vries
2019-05-16  8:17 ` [PING][PATCH][gdb] " Tom de Vries
2019-05-16 15:37 ` [PATCH][gdb] " Andrew Burgess
2019-05-17  7:41   ` Tom de Vries
2019-05-17 21:46     ` Andrew Burgess
2019-05-18  8:51       ` Andrew Burgess
2019-05-21 13:08       ` Tom de Vries
2019-05-16 18:53 ` Tom Tromey [this message]
2019-05-17  7:43   ` Tom de Vries

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878sv6w7si.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tdevries@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox