From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26130 invoked by alias); 16 May 2019 18:53:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 26025 invoked by uid 89); 16 May 2019 18:53:07 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: gateway30.websitewelcome.com Received: from gateway30.websitewelcome.com (HELO gateway30.websitewelcome.com) (192.185.197.25) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 16 May 2019 18:53:05 +0000 Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway30.websitewelcome.com (Postfix) with ESMTP id 7AB8633956 for ; Thu, 16 May 2019 13:53:03 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id RLV1hHRup2qH7RLV1hXdTl; Thu, 16 May 2019 13:53:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=OPUJ+N5t+6X7sp3W+TnfRqjkCerR8+8ZsnAcNt+iyxk=; b=MvkhZb1fB0+fAqruxD4Rh3syaJ TGLJLJIc3VcTyQ3Uc78s0dHfClS4bbro4vS8siDxaHUTtYfgKzDBzD2gCk64Uzgx104+s7MIMefKR 78r4bAR1D8xhiNQz/qXdQBiG+; Received: from 71-218-69-43.hlrn.qwest.net ([71.218.69.43]:38724 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1hRLV1-00189a-42; Thu, 16 May 2019 13:53:03 -0500 From: Tom Tromey To: Tom de Vries Cc: gdb-patches@sourceware.org Subject: Re: [PATCH][gdb] Fix heap-use-after-free in typename_concat References: <20190503093124.GA27838@delia> Date: Thu, 16 May 2019 18:53:00 -0000 In-Reply-To: <20190503093124.GA27838@delia> (Tom de Vries's message of "Fri, 3 May 2019 11:31:26 +0200") Message-ID: <878sv6w7si.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-05/txt/msg00386.txt.bz2 >>>>> "Tom" == Tom de Vries writes: Tom> When running gdb using AddressSanitizer, and loading a cc1plus binary built Tom> with profiledbootstrap and -flto, we run into a heap-use-after-free error: Thanks for finding this. Tom> + { Tom> + struct cu_partial_die_info res; Tom> + res.pdi = pd; Tom> + res.cu = cu; Tom> + return res; Tom> + } Can't this be just "return {pd, cu};"? Tom> + { Tom> + struct cu_partial_die_info res; Tom> + res.pdi = pd; Tom> + res.cu = per_cu->cu; Tom> + return res; Tom> + } If so, another instance of it. thanks, Tom