From: Andrew Burgess <aburgess@redhat.com>
To: Kevin Buettner <kevinb@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb/testsuite: add comments to line table from DWARF assembler
Date: Wed, 29 Jan 2025 10:19:40 +0000 [thread overview]
Message-ID: <878qqt9b2b.fsf@redhat.com> (raw)
In-Reply-To: <20250127181752.4a7112e9@f41-zbm-amd>
Kevin Buettner <kevinb@redhat.com> writes:
> On Mon, 27 Jan 2025 11:47:45 +0000
> Andrew Burgess <aburgess@redhat.com> wrote:
>
>> Add comments to the assembler generated by the DWARF assembler that
>> builds the line table. I found these comments useful when debugging
>> issues with the line table parsing.
>>
>> This patch should make no difference to what is being tested. The
>> test binaries should be unchanged after this commit.
>
> LGTM.
>
> Approved-by: Kevin Buettner <kevinb@redhat.com>
Pushed.
Thanks,
Andrew
prev parent reply other threads:[~2025-01-29 10:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-27 11:47 Andrew Burgess
2025-01-28 1:17 ` Kevin Buettner
2025-01-29 10:19 ` Andrew Burgess [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878qqt9b2b.fsf@redhat.com \
--to=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=kevinb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox