From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id E/ZZNDgBmmcrLh4AWB0awg (envelope-from ) for ; Wed, 29 Jan 2025 05:21:44 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=LjHF8pSV; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id C46271E105; Wed, 29 Jan 2025 05:21:44 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 6C3821E08E for ; Wed, 29 Jan 2025 05:21:44 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 128D13857B98 for ; Wed, 29 Jan 2025 10:21:44 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 128D13857B98 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=LjHF8pSV Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 82EB93857C6A for ; Wed, 29 Jan 2025 10:19:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 82EB93857C6A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 82EB93857C6A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1738145984; cv=none; b=XBuBwJPeVnD75C5IwzXb6w26ok6BAaKuqfqtfug15jszLGuQV1as7UNAsFdH4mX2Sm0J9nK7zgFnDjt/8TIUeyE9G9o1nw3/ZIr9HCHk8k5NfwjfTm/q+3auhaNlZO1m8FT4XJAn2F2PavhQjWgiOJo+hAiSZ2qNSP2ZSRQEmbg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1738145984; c=relaxed/simple; bh=wCYFAwQeSf5qqNre+nCmvVvmKz0RtFUL4pzeINBZeio=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=fwxlbCp1BEM0fwvfOmaYvoVgyfLq3/MYJuTfJsLTNHLIu3eaGDs6GGpNFU2NsyevFp0oDDklONHESEJk0/7d0fR7ofZ4mFDvQ6BAKLsR4MT4Y7s149VTl37A2MUxM/Bn2BBE+PP7mapLyk0gSu3AOnmbIKgvrqCpu2c4nqViuIM= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 82EB93857C6A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1738145984; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TLvYK3dJEPbWl6rzMdQ0RX2vrZ0wwBzbdCEKvEATmpw=; b=LjHF8pSVQCCkI0jsoRKK6n6bX0STYufZPp+mOP0h5IiIqA+v2OTz0+x1vAT2LTI3ArABax jEzB13wSH0XdoIjLzjV0xf1skhKiNb1C1Ufeh1LLmSszo6dDmNTrOlpABn2QsYU8f6XFbL EvIftw9gPpt/cl0KQPoCba5eZybwjvk= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-694-MBST1PCCMFKK9f7t3K9Hmg-1; Wed, 29 Jan 2025 05:19:43 -0500 X-MC-Unique: MBST1PCCMFKK9f7t3K9Hmg-1 X-Mimecast-MFC-AGG-ID: MBST1PCCMFKK9f7t3K9Hmg Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-385ed79291eso251466f8f.0 for ; Wed, 29 Jan 2025 02:19:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738145981; x=1738750781; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TLvYK3dJEPbWl6rzMdQ0RX2vrZ0wwBzbdCEKvEATmpw=; b=RCWr4/fltMNK68O0WSuxDVTgibahy++OWRlziSDmN+Q+I2rkEpti62GjrgZHpT8fGr 4ZEHN35J7FCrM9cgdF/dy2aesMy013yMFrCYfLD83UKyMpE+eCuqLLztyog8avctPubw dxXKkwEzwR7qh36hB5pk8jlkWh1hiV8pmmfc2mt4U3dHXiQqq9y+aaNviWk+S/HHO/6p ToC4Bo8AiUJ10BHx3WzPw/dNl4WM9/R2CKnC8QCesoxEgL39oW6bd86xjTh6GvLxEnHL lzCH19Amb+lZjKjK8HNgi0jB9mZCSG/xIpBGpSUH5PuTOmdiI/KpeWyB6Lvqvw34hLUw SfvA== X-Gm-Message-State: AOJu0Ywcl6OQsM4uA9AZiF3PEigQCoyQTQ8VcaCBDAtWCPMFKRtgX8dq qw4O3fs66lRHbhQzOdC9nJcrRrGM4Vv3jarGBJ8vOwmbaSm9APqGxLb3d8fyHPDAu8YCHb7iCf5 NVk1YlnXP8zoZRZFxJGkOfyjR8HTeFxUKHqY2qkCzqNG4zr2rWMIkk9+7vqp5JdDCo7U= X-Gm-Gg: ASbGncs4KPQhYGHikt8uvW4zXtRjbGycItvCHwo6NSitJJB6b46WPVloNhmHWVtJrml Ifh4/97UWU2YcIGco91DMUUtlxkf03sCJgGDbyx6bvSfZubHLQt5nr52N3pEMfC9SxaNfhwItfN kBdJRE6H5NVNKUo57DsfkAgaOVkP2U/k63Dd+3j+464NiCt3dj3Sn3SsFC4LQ26+4NDQ2lRk24O PxTGecG4H6KyA7EMa8FN9cmgukUM+90fTiYYmaAGqGfql/rNyAgIbP2Biqjc3HkoS4ufyVlJ8dV tp5AdYNt0bcVN3Hk4Z0okxjD+sobnA== X-Received: by 2002:a05:6000:4022:b0:38a:88d0:1c9c with SMTP id ffacd0b85a97d-38c50ff1e18mr1836432f8f.17.1738145981187; Wed, 29 Jan 2025 02:19:41 -0800 (PST) X-Google-Smtp-Source: AGHT+IHYmgYYNJ1mZ+MGilP+jxqQKWHI2R7yQPwCqG/shgNG8LWU8QsmIA5LQ/cE16FhHZR7LjQYWA== X-Received: by 2002:a05:6000:4022:b0:38a:88d0:1c9c with SMTP id ffacd0b85a97d-38c50ff1e18mr1836417f8f.17.1738145980876; Wed, 29 Jan 2025 02:19:40 -0800 (PST) Received: from localhost (44.226.159.143.dyn.plus.net. [143.159.226.44]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38c2a1144f6sm16364448f8f.0.2025.01.29.02.19.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Jan 2025 02:19:40 -0800 (PST) From: Andrew Burgess To: Kevin Buettner Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb/testsuite: add comments to line table from DWARF assembler In-Reply-To: <20250127181752.4a7112e9@f41-zbm-amd> References: <20250127181752.4a7112e9@f41-zbm-amd> Date: Wed, 29 Jan 2025 10:19:40 +0000 Message-ID: <878qqt9b2b.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: BsiW7MUrEjbHo3Li9lz_eC6gmacWKl9J2UIBNWVuZ8s_1738145982 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Kevin Buettner writes: > On Mon, 27 Jan 2025 11:47:45 +0000 > Andrew Burgess wrote: > >> Add comments to the assembler generated by the DWARF assembler that >> builds the line table. I found these comments useful when debugging >> issues with the line table parsing. >> >> This patch should make no difference to what is being tested. The >> test binaries should be unchanged after this commit. > > LGTM. > > Approved-by: Kevin Buettner Pushed. Thanks, Andrew