From: Tom Tromey <tromey@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: Regression for -gstabs+ [Re: FYI: fix spelling of "delete" in c-exp.y]
Date: Tue, 19 Jun 2012 14:10:00 -0000 [thread overview]
Message-ID: <877gv3pf4g.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20120619104843.GA22015@host2.jankratochvil.net> (Jan Kratochvil's message of "Tue, 19 Jun 2012 12:48:43 +0200")
Jan> this exactly reverts my change:
Jan> [WIP patch] Fix crash regressions after libiberty/ update
Jan> http://sourceware.org/ml/gdb-patches/2012-01/msg00261.html
Jan> I made there this change to match libiberty/cp-demangle.c
Jan> cplus_demangle_operators[].
Sorry.
I'll revert it and figure out a different fix.
Why are we spending any time at all on stabs and C++? IIRC that never
really worked that well, and stabs are past obsolete.
>> Debugging one of these showed that there were some extra spaces in
>> c-exp.y, that caused problems in this test case. This patch removes the
>> spaces.
Jan> "Extra" why? There seem to be missing spaces vs. the demanger now.
I will debug it again, but right now I don't understand this.
The demangler will add argument types as well.
When can you end up with a symbol name with a trailing space?
Tom
next prev parent reply other threads:[~2012-06-19 14:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-18 20:22 FYI: fix spelling of "delete" in c-exp.y Tom Tromey
2012-06-19 10:49 ` Regression for -gstabs+ [Re: FYI: fix spelling of "delete" in c-exp.y] Jan Kratochvil
2012-06-19 14:10 ` Tom Tromey [this message]
2012-06-19 15:05 ` Jan Kratochvil
2012-06-19 17:24 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877gv3pf4g.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox