From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19386 invoked by alias); 19 Jun 2012 14:10:10 -0000 Received: (qmail 19373 invoked by uid 22791); 19 Jun 2012 14:10:08 -0000 X-SWARE-Spam-Status: No, hits=-6.4 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 19 Jun 2012 14:09:53 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q5JE9qgx027681 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 19 Jun 2012 10:09:52 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q5JE9pxo004558 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Tue, 19 Jun 2012 10:09:52 -0400 From: Tom Tromey To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: Regression for -gstabs+ [Re: FYI: fix spelling of "delete" in c-exp.y] References: <87k3z4pdzg.fsf@fleche.redhat.com> <20120619104843.GA22015@host2.jankratochvil.net> Date: Tue, 19 Jun 2012 14:10:00 -0000 In-Reply-To: <20120619104843.GA22015@host2.jankratochvil.net> (Jan Kratochvil's message of "Tue, 19 Jun 2012 12:48:43 +0200") Message-ID: <877gv3pf4g.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-06/txt/msg00612.txt.bz2 Jan> this exactly reverts my change: Jan> [WIP patch] Fix crash regressions after libiberty/ update Jan> http://sourceware.org/ml/gdb-patches/2012-01/msg00261.html Jan> I made there this change to match libiberty/cp-demangle.c Jan> cplus_demangle_operators[]. Sorry. I'll revert it and figure out a different fix. Why are we spending any time at all on stabs and C++? IIRC that never really worked that well, and stabs are past obsolete. >> Debugging one of these showed that there were some extra spaces in >> c-exp.y, that caused problems in this test case. This patch removes the >> spaces. Jan> "Extra" why? There seem to be missing spaces vs. the demanger now. I will debug it again, but right now I don't understand this. The demangler will add argument types as well. When can you end up with a symbol name with a trailing space? Tom