Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Jan Kratochvil <jan.kratochvil@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [patch 2/2] Assert leftover cleanups in TRY_CATCH
Date: Tue, 07 May 2013 15:26:00 -0000	[thread overview]
Message-ID: <877gjavmje.fsf@fleche.redhat.com> (raw)
In-Reply-To: <87ip2uvonz.fsf@fleche.redhat.com> (Tom Tromey's message of "Tue,	07 May 2013 08:40:32 -0600")

Tom> Alternatively I think we could probably change all the code to be
Tom> cleanup-checker-clean.  I'll try to prep that series soon to see what
Tom> people think.  I think it actually less work.

Actually, I forgot how hard this is.

There are some tricky cases -- e.g., try to remove the dangling cleanup
from c-exp.y:operator_stoken, or from
ada-lang.c:old_renaming_is_invisible.

Or, there is some spaghetti code, like
disasm.c:do_mixed_source_and_assembly.

And, there is some code where I don't know what is intended, like
record-full.c:record_full_wait_1 (multiple returns without cleaning up),
or record-btrace.c:record_btrace_insn_history.

So, getting to zero complaints from the checker is not easy.
Maybe I will hack the checker to ignore some issues.

Tom


  parent reply	other threads:[~2013-05-07 15:26 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-01 16:57 Jan Kratochvil
2013-05-02 17:02 ` Pedro Alves
2013-05-05 16:56   ` [commit] " Jan Kratochvil
2013-05-06 17:57 ` Tom Tromey
2013-05-06 18:18   ` Jan Kratochvil
2013-05-06 18:50     ` Tom Tromey
2013-05-07  1:47       ` Jan Kratochvil
2013-05-07  4:37         ` Doug Evans
2013-05-07  4:49           ` Doug Evans
2013-05-07 15:24           ` Jan Kratochvil
2013-05-15  0:13             ` Benchmarking (was Re: [patch 2/2] Assert leftover cleanups in TRY_CATCH) Stan Shebs
2013-05-15 17:00               ` Doug Evans
2013-05-22 20:51                 ` Tom Tromey
2013-05-07 14:36         ` [patch 2/2] Assert leftover cleanups in TRY_CATCH Tom Tromey
2013-05-07 18:00           ` Jan Kratochvil
2013-05-07  6:23   ` Joel Brobecker
2013-05-07 14:20     ` [patch] " Jan Kratochvil
2013-05-14 20:39       ` [commit] " Jan Kratochvil
2013-05-07 14:40     ` Tom Tromey
2013-05-07 14:55       ` Jan Kratochvil
2013-05-07 15:26       ` Tom Tromey [this message]
2013-05-08  5:54       ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877gjavmje.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox