Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: gdb-patches@sourceware.org
Subject: [patch 2/2] Assert leftover cleanups in TRY_CATCH
Date: Wed, 01 May 2013 16:57:00 -0000	[thread overview]
Message-ID: <20130501165750.GA453@host2.jankratochvil.net> (raw)

Hi,

as discussed in:
	Re: Cleanups and Exception handlers
	http://sourceware.org/ml/gdb/2013-05/msg00007.html
	Message-ID: <20130501152116.GA7529@host2.jankratochvil.net>

this gdb_assert can be useful.  Unfortunately there may be leftover
"regressions" due to it not caught by the testsuite.


Thanks,
Jan


gdb/
2013-05-01  Jan Kratochvil  <jan.kratochvil@redhat.com>

	* cleanups.c (restore_my_cleanups): New gdb_assert for SENTINEL_CLEANUP.

diff --git a/gdb/cleanups.c b/gdb/cleanups.c
index c403db7..02db9f5 100644
--- a/gdb/cleanups.c
+++ b/gdb/cleanups.c
@@ -261,6 +261,7 @@ save_final_cleanups (void)
 static void
 restore_my_cleanups (struct cleanup **pmy_chain, struct cleanup *chain)
 {
+  gdb_assert (*pmy_chain == SENTINEL_CLEANUP);
   *pmy_chain = chain;
 }
 


             reply	other threads:[~2013-05-01 16:57 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-01 16:57 Jan Kratochvil [this message]
2013-05-02 17:02 ` Pedro Alves
2013-05-05 16:56   ` [commit] " Jan Kratochvil
2013-05-06 17:57 ` Tom Tromey
2013-05-06 18:18   ` Jan Kratochvil
2013-05-06 18:50     ` Tom Tromey
2013-05-07  1:47       ` Jan Kratochvil
2013-05-07  4:37         ` Doug Evans
2013-05-07  4:49           ` Doug Evans
2013-05-07 15:24           ` Jan Kratochvil
2013-05-15  0:13             ` Benchmarking (was Re: [patch 2/2] Assert leftover cleanups in TRY_CATCH) Stan Shebs
2013-05-15 17:00               ` Doug Evans
2013-05-22 20:51                 ` Tom Tromey
2013-05-07 14:36         ` [patch 2/2] Assert leftover cleanups in TRY_CATCH Tom Tromey
2013-05-07 18:00           ` Jan Kratochvil
2013-05-07  6:23   ` Joel Brobecker
2013-05-07 14:20     ` [patch] " Jan Kratochvil
2013-05-14 20:39       ` [commit] " Jan Kratochvil
2013-05-07 14:40     ` Tom Tromey
2013-05-07 14:55       ` Jan Kratochvil
2013-05-07 15:26       ` Tom Tromey
2013-05-08  5:54       ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130501165750.GA453@host2.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox