From: Yao Qi <yao@codesourcery.com>
To: Don Breazeal <donb@codesourcery.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Skipping tests that use remote protocol
Date: Fri, 12 Dec 2014 03:12:00 -0000 [thread overview]
Message-ID: <877fxxzhmx.fsf@codesourcery.com> (raw)
In-Reply-To: <1418344896-9036-1-git-send-email-donb@codesourcery.com> (Don Breazeal's message of "Thu, 11 Dec 2014 16:41:36 -0800")
Don Breazeal <donb@codesourcery.com> writes:
> Other procedures are also used that don't really check the right thing.
>
> * isnative checks the build triplet against the target triplet.
>
> * gdb_is_target_remote and target_is_gdbserver don't differentiate between
> remote and extended-remote. Both require GDB to be running, which makes
> using them to skip a test less efficient than a procedure that uses info
> from the target board config file.
>
> * target_info use_gdb_stub is used in lib/gdb.exp to explicitly determine
> if a target is remote and not extended-remote.
>
> If we reach consensus on this approach I'll follow up with patches to
> convert other tests to use these procedures instead of is_remote,
> isnative, and so on.
Does "![isnative] || [is_remote host] || [target_info exists use_gdb_stub]"
work for you? It is used in some attach related tests.
--
Yao (齐尧)
next prev parent reply other threads:[~2014-12-12 3:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-12 0:41 Don Breazeal
2014-12-12 3:12 ` Yao Qi [this message]
2014-12-12 19:00 ` Breazeal, Don
2014-12-15 11:59 ` Yao Qi
2014-12-15 18:03 ` Breazeal, Don
2014-12-18 12:16 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877fxxzhmx.fsf@codesourcery.com \
--to=yao@codesourcery.com \
--cc=donb@codesourcery.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox