From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11416 invoked by alias); 12 Dec 2014 03:12:09 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 11403 invoked by uid 89); 12 Dec 2014 03:12:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 12 Dec 2014 03:12:05 +0000 Received: from svr-orw-fem-04.mgc.mentorg.com ([147.34.97.41]) by relay1.mentorg.com with esmtp id 1XzGeA-0005LZ-7e from Yao_Qi@mentor.com for gdb-patches@sourceware.org; Thu, 11 Dec 2014 19:12:02 -0800 Received: from GreenOnly (147.34.91.1) by svr-orw-fem-04.mgc.mentorg.com (147.34.97.41) with Microsoft SMTP Server id 14.3.181.6; Thu, 11 Dec 2014 19:12:01 -0800 From: Yao Qi To: Don Breazeal CC: Subject: Re: [PATCH] Skipping tests that use remote protocol References: <1418344896-9036-1-git-send-email-donb@codesourcery.com> Date: Fri, 12 Dec 2014 03:12:00 -0000 In-Reply-To: <1418344896-9036-1-git-send-email-donb@codesourcery.com> (Don Breazeal's message of "Thu, 11 Dec 2014 16:41:36 -0800") Message-ID: <877fxxzhmx.fsf@codesourcery.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2014-12/txt/msg00262.txt.bz2 Don Breazeal writes: > Other procedures are also used that don't really check the right thing. > > * isnative checks the build triplet against the target triplet. > > * gdb_is_target_remote and target_is_gdbserver don't differentiate between > remote and extended-remote. Both require GDB to be running, which makes > using them to skip a test less efficient than a procedure that uses info > from the target board config file. > > * target_info use_gdb_stub is used in lib/gdb.exp to explicitly determine > if a target is remote and not extended-remote. > > If we reach consensus on this approach I'll follow up with patches to > convert other tests to use these procedures instead of is_remote, > isnative, and so on. Does "![isnative] || [is_remote host] || [target_info exists use_gdb_stub]" work for you? It is used in some attach related tests. --=20 Yao (=E9=BD=90=E5=B0=A7)