From: Sergio Durigan Junior <sergiodj@redhat.com>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: paul cannon <paul@thepaul.org>, gdb-patches@sourceware.org
Subject: Re: [PATCH][PR python/21460] Avoid segfault during Python cleanup
Date: Thu, 15 Jun 2017 20:30:00 -0000 [thread overview]
Message-ID: <877f0d6lkf.fsf@redhat.com> (raw)
In-Reply-To: <69e1e2d6b7054702d39a081238590633@polymtl.ca> (Simon Marchi's message of "Sun, 11 Jun 2017 22:59:19 +0200")
On Sunday, June 11 2017, Simon Marchi wrote:
>>
>> python/21460
>> * python.c (gdbpy_set_quit_flag) Check Py_IsInitialized() before
>> calling PyErr_SetInterrupt(), as Python may be shutting down already.
>
> The ChangeLog should only contain "what" changed and not "why". So
> just the first part:
>
> Check Py_IsInitialized() before calling PyErr_SetInterrupt().
>
> is sufficient. However, the why should be contained in the commit
> message. You did a good job at explaining the problem in the bug you
> filed, so I think you could just take that and put it in the commit
> log (and massage it a bit if needed).
Also, I think it's worth mentioning that the ChangeLog lines shouldn't
exceed 76 chars (soft limit). And the file 'python.c' is inside the
python/ directory. So a good example would be:
yyyy-mm-dd Name <email>
PR python/21460
* python/python.c: Check Py_IsInitialized() before calling
PyErr_SetInterrupt().
Cheers,
--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/
prev parent reply other threads:[~2017-06-15 20:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-25 16:26 paul cannon
2017-06-11 20:59 ` Simon Marchi
2017-06-15 20:30 ` Sergio Durigan Junior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877f0d6lkf.fsf@redhat.com \
--to=sergiodj@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=paul@thepaul.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox