From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 49420 invoked by alias); 15 Jun 2017 20:30:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 49188 invoked by uid 89); 15 Jun 2017 20:30:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=massage, H*Ad:U*paul X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 15 Jun 2017 20:30:20 +0000 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1FF9E6413E; Thu, 15 Jun 2017 20:30:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 1FF9E6413E Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=sergiodj@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 1FF9E6413E Received: from localhost (unused-10-15-17-193.yyz.redhat.com [10.15.17.193]) by smtp.corp.redhat.com (Postfix) with ESMTPS id ADC37784D3; Thu, 15 Jun 2017 20:30:08 +0000 (UTC) From: Sergio Durigan Junior To: Simon Marchi Cc: paul cannon , gdb-patches@sourceware.org Subject: Re: [PATCH][PR python/21460] Avoid segfault during Python cleanup References: <20170525162612.GA10119@turing> <69e1e2d6b7054702d39a081238590633@polymtl.ca> X-URL: https://sergiodj.net Date: Thu, 15 Jun 2017 20:30:00 -0000 In-Reply-To: <69e1e2d6b7054702d39a081238590633@polymtl.ca> (Simon Marchi's message of "Sun, 11 Jun 2017 22:59:19 +0200") Message-ID: <877f0d6lkf.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2017-06/txt/msg00451.txt.bz2 On Sunday, June 11 2017, Simon Marchi wrote: >> >> python/21460 >> * python.c (gdbpy_set_quit_flag) Check Py_IsInitialized() before >> calling PyErr_SetInterrupt(), as Python may be shutting down already. > > The ChangeLog should only contain "what" changed and not "why". So > just the first part: > > Check Py_IsInitialized() before calling PyErr_SetInterrupt(). > > is sufficient. However, the why should be contained in the commit > message. You did a good job at explaining the problem in the bug you > filed, so I think you could just take that and put it in the commit > log (and massage it a bit if needed). Also, I think it's worth mentioning that the ChangeLog lines shouldn't exceed 76 chars (soft limit). And the file 'python.c' is inside the python/ directory. So a good example would be: yyyy-mm-dd Name PR python/21460 * python/python.c: Check Py_IsInitialized() before calling PyErr_SetInterrupt(). Cheers, -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/