From: Tom Tromey <tom@tromey.com>
To: Weimin Pan <weimin.pan@oracle.com>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH v3 PR gdb/16841] virtual inheritance via typedef cannot find base
Date: Thu, 04 Oct 2018 22:20:00 -0000 [thread overview]
Message-ID: <877eixicc1.fsf@tromey.com> (raw)
In-Reply-To: <8c8e0eb6-245c-40c0-456e-9f49ccb92b74@oracle.com> (Weimin Pan's message of "Tue, 18 Sep 2018 16:25:54 -0700")
Sorry, I forgot about this.
Tom> The code has a loop to deal with multiple inheritance but the test
Tom> doesn't exercise this case. I think an additional for that would be
Tom> good.
Weimin> Sorry, which case is not exercised? Could it be printing superbase
Weimin> class member in base?
There's this loop in get_baseclass_offset:
+ for (int i = 0; i < TYPE_N_BASECLASSES (vt); i++)
However, all the classes in virtbase2.cc use single inheritance, so when
testing, the loop only loops once. I think it would be good to test a
multiple inheritance case.
Tom
next prev parent reply other threads:[~2018-10-04 22:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-13 1:39 Weimin Pan
2018-09-14 18:26 ` Simon Marchi
2018-09-14 21:49 ` Weimin Pan
2018-09-18 11:59 ` Tom Tromey
2018-09-18 23:26 ` Weimin Pan
2018-10-04 22:20 ` Tom Tromey [this message]
2018-10-04 23:51 ` Wei-min Pan
2018-10-05 14:02 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877eixicc1.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=weimin.pan@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox