From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10117 invoked by alias); 4 Oct 2018 22:20:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 10071 invoked by uid 89); 4 Oct 2018 22:20:14 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway31.websitewelcome.com Received: from gateway31.websitewelcome.com (HELO gateway31.websitewelcome.com) (192.185.144.219) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 04 Oct 2018 22:20:12 +0000 Received: from cm15.websitewelcome.com (cm15.websitewelcome.com [100.42.49.9]) by gateway31.websitewelcome.com (Postfix) with ESMTP id 45BF6DA0CAB for ; Thu, 4 Oct 2018 17:20:11 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 8ByRgic018YaU8ByXgBF34; Thu, 04 Oct 2018 17:20:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=6F41gLHKSXXxhQtpjGVZheaoWsMomsahgxgdZuZv/X8=; b=BvgCkMOiG0da6C3DMfCp80qIOL VO8rZjkRDYkSbaIYBLkk9RKcdiz7wbBcdRyczVCgYq2RMC4aW56OJPxaTZ3YV6ReJ6LN3pNRYUHpD Eg8I6DrqHkasTAC3JwhNvSbVX; Received: from 97-122-190-66.hlrn.qwest.net ([97.122.190.66]:53296 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1g8ByR-0019vo-Bg; Thu, 04 Oct 2018 17:19:59 -0500 From: Tom Tromey To: Weimin Pan Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH v3 PR gdb/16841] virtual inheritance via typedef cannot find base References: <1536800471-78975-1-git-send-email-weimin.pan@oracle.com> <87r2hrt3s6.fsf@tromey.com> <8c8e0eb6-245c-40c0-456e-9f49ccb92b74@oracle.com> Date: Thu, 04 Oct 2018 22:20:00 -0000 In-Reply-To: <8c8e0eb6-245c-40c0-456e-9f49ccb92b74@oracle.com> (Weimin Pan's message of "Tue, 18 Sep 2018 16:25:54 -0700") Message-ID: <877eixicc1.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-10/txt/msg00119.txt.bz2 Sorry, I forgot about this. Tom> The code has a loop to deal with multiple inheritance but the test Tom> doesn't exercise this case. I think an additional for that would be Tom> good. Weimin> Sorry, which case is not exercised? Could it be printing superbase Weimin> class member in base? There's this loop in get_baseclass_offset: + for (int i = 0; i < TYPE_N_BASECLASSES (vt); i++) However, all the classes in virtbase2.cc use single inheritance, so when testing, the loop only loops once. I think it would be good to test a multiple inheritance case. Tom