From: Tom Tromey <tom@tromey.com>
To: Paul Marechal <paul.marechal@ericsson.com>
Cc: "gdb-patches\@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] gdb: Fix "info os <unknown>" command
Date: Fri, 21 Dec 2018 17:31:00 -0000 [thread overview]
Message-ID: <877eg2ss5u.fsf@tromey.com> (raw)
In-Reply-To: <20181217221253.13314-1-paul.marechal@ericsson.com> (Paul Marechal's message of "Mon, 17 Dec 2018 22:13:16 +0000")
>>>>> "Paul" == Paul Marechal <paul.marechal@ericsson.com> writes:
Paul> Running `info os someUnknownOsType` is crashing when gdb is built with
Paul> -D_GLIBCXX_DEBUG:
Paul> /usr/include/c++/5/debug/vector:439:error: attempt to
Paul> access an element in
Paul> an empty container.
Thank you for the patch.
Someday I hope to send a patch to enable -D_GLIBCXX_DEBUG by default
when building gdb in not-release mode.
Paul> This is a regression in gdb 8.2 and this patch restores the behavior of
Paul> previous versions.
Perhaps it isn't too late to put this on the 8.2 branch, as it seems
simple enough.
Paul> PR gdb/23974
Paul> * target.c (target_read_stralloc): Check for empty vector.
Paul> gdb/testsuite/ChangeLog:
Paul> PR gdb/23974
Paul> * gdb.base/info-os.exp: Check return for unknown "info os" type.
This is ok.
Tom
next prev parent reply other threads:[~2018-12-21 17:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-17 22:13 Paul Marechal
2018-12-21 17:31 ` Tom Tromey [this message]
2018-12-21 18:06 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877eg2ss5u.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=paul.marechal@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox