From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 44527 invoked by alias); 21 Dec 2018 17:31:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 43023 invoked by uid 89); 21 Dec 2018 17:31:29 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:882 X-HELO: gateway23.websitewelcome.com Received: from gateway23.websitewelcome.com (HELO gateway23.websitewelcome.com) (192.185.48.104) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 21 Dec 2018 17:31:28 +0000 Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway23.websitewelcome.com (Postfix) with ESMTP id BDFA1FC56 for ; Fri, 21 Dec 2018 11:31:26 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id aOdygTbrd2qH7aOdygC2u8; Fri, 21 Dec 2018 11:31:26 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=6nUCrohToQxA7xc6yqTrFEqvijpqwL0eSsqkqNx42kY=; b=abREuqd84e8uPYwGkwzp31N2NU mrcMtBEYEwPAUD0m1wxFeWd/zFZNHdBy3t1Nyutk+PIG7qdyP4UnvjdhruZw5x19cz5lAWquCS/ub di/ic9kse3V0m2J2yjL0lzpOc; Received: from 75-166-72-210.hlrn.qwest.net ([75.166.72.210]:58514 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1gaOdy-0037vC-GI; Fri, 21 Dec 2018 11:31:26 -0600 From: Tom Tromey To: Paul Marechal Cc: "gdb-patches\@sourceware.org" Subject: Re: [PATCH] gdb: Fix "info os " command References: <20181217221253.13314-1-paul.marechal@ericsson.com> Date: Fri, 21 Dec 2018 17:31:00 -0000 In-Reply-To: <20181217221253.13314-1-paul.marechal@ericsson.com> (Paul Marechal's message of "Mon, 17 Dec 2018 22:13:16 +0000") Message-ID: <877eg2ss5u.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-12/txt/msg00253.txt.bz2 >>>>> "Paul" == Paul Marechal writes: Paul> Running `info os someUnknownOsType` is crashing when gdb is built with Paul> -D_GLIBCXX_DEBUG: Paul> /usr/include/c++/5/debug/vector:439:error: attempt to Paul> access an element in Paul> an empty container. Thank you for the patch. Someday I hope to send a patch to enable -D_GLIBCXX_DEBUG by default when building gdb in not-release mode. Paul> This is a regression in gdb 8.2 and this patch restores the behavior of Paul> previous versions. Perhaps it isn't too late to put this on the 8.2 branch, as it seems simple enough. Paul> PR gdb/23974 Paul> * target.c (target_read_stralloc): Check for empty vector. Paul> gdb/testsuite/ChangeLog: Paul> PR gdb/23974 Paul> * gdb.base/info-os.exp: Check return for unknown "info os" type. This is ok. Tom